Update termthemes.json #2173
Update termthemes.json #2173
Conversation
New theme for wave
|
|
WalkthroughA new terminal color theme called "Blue Matrix" has been added to the termthemes.json configuration file in the defaultconfig directory. This theme includes a display name, display order, and a full set of color definitions for standard, bright, background, foreground, selection background, and cursor colors, all specified in hexadecimal format. The theme is appended after the existing "rosepine" entry, thereby increasing the number of available terminal themes in the configuration file. No other changes or modifications to existing themes or configurations are present. Note ⚡️ AI Code Reviews for VS Code, Cursor, WindsurfCodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback. Note ⚡️ Faster reviews with cachingCodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting
📒 Files selected for processing (1)
pkg/wconfig/defaultconfig/termthemes.json(1 hunks)
🔇 Additional comments (1)
pkg/wconfig/defaultconfig/termthemes.json (1)
177-177: Correct JSON object separation
The comma after the"rosepine"block is required to validly separate it from the next object. This change is correct.
| "Blue Matrix": { | ||
| "display:name": "Blue Matrix", | ||
| "display:order": 8, | ||
| "black": "#101116", | ||
| "red": "#ff5680", | ||
| "green": "#00ff9c", | ||
| "yellow": "#fffc58", | ||
| "blue": "#00b0ff", | ||
| "purple": "#d57bff", | ||
| "cyan": "#76c1ff", | ||
| "white": "#c7c7c7", | ||
| "brightBlack": "#686868", | ||
| "brightRed": "#ff6e67", | ||
| "brightGreen": "#5ffa68", | ||
| "brightYellow": "#fffc67", | ||
| "brightBlue": "#6871ff", | ||
| "brightPurple": "#d682ec", | ||
| "brightCyan": "#60fdff", | ||
| "brightWhite": "#ffffff", | ||
| "background": "#101116", | ||
| "foreground": "#00a2ff", | ||
| "selectionBackground": "#c1deff", | ||
| "cursorColor": "#76ff9f" | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Ensure theme identifier and property naming consistency
- The JSON key
"Blue Matrix"contains spaces and uppercase letters. Use a lowercase slug (e.g.,"blue-matrix") to follow the existing theme ID pattern and avoid potential runtime lookup issues. - Replace custom properties
"purple"/"brightPurple"with"magenta"/"brightMagenta"to align with the other theme entries. - Rename
"cursorColor"to"cursor"for consistency with existing themes. - Verify if
"gray"and"cmdtext"keys are required by the application; if so, consider adding them here as in other entries.
- "Blue Matrix": {
+ "blue-matrix": {
"display:name": "Blue Matrix",
"display:order": 8,
"black": "#101116",
"red": "#ff5680",
"green": "#00ff9c",
"yellow": "#fffc58",
"blue": "#00b0ff",
- "purple": "#d57bff",
+ "magenta": "#d57bff",
"cyan": "#76c1ff",
"white": "#c7c7c7",
"brightBlack": "#686868",
"brightRed": "#ff6e67",
"brightGreen": "#5ffa68",
"brightYellow": "#fffc67",
"brightBlue": "#6871ff",
- "brightPurple": "#d682ec",
+ "brightMagenta": "#d682ec",
"brightCyan": "#60fdff",
"brightWhite": "#ffffff",
"background": "#101116",
"foreground": "#00a2ff",
"selectionBackground": "#c1deff",
- "cursorColor": "#76ff9f"
+ "cursor": "#76ff9f",
+ // Optional keys for completeness:
+ // "gray": "<hex>",
+ // "cmdtext": "<hex>"
}📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "Blue Matrix": { | |
| "display:name": "Blue Matrix", | |
| "display:order": 8, | |
| "black": "#101116", | |
| "red": "#ff5680", | |
| "green": "#00ff9c", | |
| "yellow": "#fffc58", | |
| "blue": "#00b0ff", | |
| "purple": "#d57bff", | |
| "cyan": "#76c1ff", | |
| "white": "#c7c7c7", | |
| "brightBlack": "#686868", | |
| "brightRed": "#ff6e67", | |
| "brightGreen": "#5ffa68", | |
| "brightYellow": "#fffc67", | |
| "brightBlue": "#6871ff", | |
| "brightPurple": "#d682ec", | |
| "brightCyan": "#60fdff", | |
| "brightWhite": "#ffffff", | |
| "background": "#101116", | |
| "foreground": "#00a2ff", | |
| "selectionBackground": "#c1deff", | |
| "cursorColor": "#76ff9f" | |
| } | |
| "blue-matrix": { | |
| "display:name": "Blue Matrix", | |
| "display:order": 8, | |
| "black": "#101116", | |
| "red": "#ff5680", | |
| "green": "#00ff9c", | |
| "yellow": "#fffc58", | |
| "blue": "#00b0ff", | |
| "magenta": "#d57bff", | |
| "cyan": "#76c1ff", | |
| "white": "#c7c7c7", | |
| "brightBlack": "#686868", | |
| "brightRed": "#ff6e67", | |
| "brightGreen": "#5ffa68", | |
| "brightYellow": "#fffc67", | |
| "brightBlue": "#6871ff", | |
| "brightMagenta": "#d682ec", | |
| "brightCyan": "#60fdff", | |
| "brightWhite": "#ffffff", | |
| "background": "#101116", | |
| "foreground": "#00a2ff", | |
| "selectionBackground": "#c1deff", | |
| "cursor": "#76ff9f", | |
| // Optional keys for completeness: | |
| // "gray": "<hex>", | |
| // "cmdtext": "<hex>" | |
| } |
🤖 Prompt for AI Agents
In pkg/wconfig/defaultconfig/termthemes.json from lines 178 to 201, rename the
theme key "Blue Matrix" to a lowercase slug "blue-matrix" to maintain
consistency. Change the color properties "purple" and "brightPurple" to
"magenta" and "brightMagenta" respectively. Rename the "cursorColor" property to
"cursor" to match other themes. Additionally, check if "gray" and "cmdtext"
properties are needed and add them if required for consistency.
New theme for wave