feat: add formulas 6.36, 6.37, and 6.38 implementations and tests #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
Thank you so much for contributing to Blueprints! This is your Pull Request # 18 to this project. Now that you've created your pull request, please don't go away; take a look at the bottom of this page for the automated checks that should already be running. If they pass, great! If not, please click on 'Details' and see if you can fix the problem they've identified. A maintainer should be along shortly to review your pull request and help get it added! |
…m-eurocode-1993-1-1
…ence equations 6.38a and 6.38n
…1993-1-1' of https://github.com/Blueprints-org/blueprints into 592-formula-request-add-formulas-636-638-from-eurocode-1993-1-1
…lude correct article number
viktor-rick
added
the
in review
viktor-rick
reviewed
May 7, 2025
Comment on lines
+19
to
+20
| a: float, | ||
| n: float, |
There was a problem hiding this comment.
Suggested change
| a: float, | |
| n: float, | |
| a: DIMENSIONLESS, | |
| n: DIMENSIONLESS, |
| from blueprints.codes.eurocode.nen_en_1993_1_1_c2_a1_2016 import NEN_EN_1993_1_1_C2_A1_2016 | ||
| from blueprints.codes.formula import Formula | ||
| from blueprints.codes.latex_formula import LatexFormula, latex_replace_symbols | ||
| from blueprints.type_alias import NMM |
There was a problem hiding this comment.
Suggested change
| from blueprints.type_alias import NMM | |
| from blueprints.type_alias import NMM, DIMENSIONLESS |
Comment on lines
+30
to
+33
| a : float | ||
| Reduction factor for cross-sectional area, see equation 6.38a. | ||
| n : float | ||
| Axial force ratio, see equation 6.38n. |
There was a problem hiding this comment.
Suggested change
| a : float | |
| Reduction factor for cross-sectional area, see equation 6.38a. | |
| n : float | |
| Axial force ratio, see equation 6.38n. | |
| a : DIMENSIONLESS | |
| Reduction factor for cross-sectional area, see equation 6.38a. | |
| n : DIMENSIONLESS | |
| Axial force ratio, see equation 6.38n. |
| n: float, | ||
| ) -> NMM: | ||
| """Evaluates the formula, for more information see the __init__ method.""" | ||
| raise_if_less_or_equal_to_zero(a=a) |
There was a problem hiding this comment.
not necessarily right?
Comment on lines
+43
to
+45
| a: float, | ||
| n: float, | ||
| ) -> NMM: |
There was a problem hiding this comment.
Suggested change
| a: float, | |
| n: float, | |
| ) -> NMM: | |
| a: DIMENSIONLESS, | |
| n: DIMENSIONLESS, | |
| ) -> NMM: |
Comment on lines
+30
to
+34
| a : float | ||
| Reduction factor for cross-sectional area, see equation 6.38a. | ||
| n : float | ||
| Axial force ratio, see equation 6.38n. | ||
| """ |
There was a problem hiding this comment.
Suggested change
| a : float | |
| Reduction factor for cross-sectional area, see equation 6.38a. | |
| n : float | |
| Axial force ratio, see equation 6.38n. | |
| """ | |
| a : DIMENSIONLESS | |
| Reduction factor for cross-sectional area, see equation 6.38a. | |
| n : DIMENSIONLESS | |
| Axial force ratio, see equation 6.38n. | |
| """ |
Comment on lines
+19
to
+20
| a: float, | ||
| n: float, |
There was a problem hiding this comment.
Suggested change
| a: float, | |
| n: float, | |
| a: DIMENSIONLESS, | |
| n: DIMENSIONLESS, |
| from blueprints.codes.eurocode.nen_en_1993_1_1_c2_a1_2016 import NEN_EN_1993_1_1_C2_A1_2016 | ||
| from blueprints.codes.formula import Formula | ||
| from blueprints.codes.latex_formula import LatexFormula, latex_replace_symbols | ||
| from blueprints.type_alias import MM, MM2, NMM, N |
There was a problem hiding this comment.
Suggested change
| from blueprints.type_alias import MM, MM2, NMM, N | |
| from blueprints.type_alias import MM, MM2, NMM, N, DIMENSIONLESS |
Comment on lines
+43
to
+44
| a: float, | ||
| n: float, |
There was a problem hiding this comment.
Suggested change
| a: float, | |
| n: float, | |
| a: DIMENSIONLESS, | |
| n: DIMENSIONLESS, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add formulas 6.36, 6.37, and 6.38 implementations and tests. with n and a being single use formula, i plugged it into the main equation like it has been done many times in blueprints.
Fixes #592
Type of change
Checklist: