Conversation
|
Are there any plans to merge this? |
|
Hope someone can review this soon... |
|
Thanks @m-rola for stepping up and writing this patch. |
Author
|
@xerial can we proceed with merge or I'm missing something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix
Fixes #732 - Out-of-bounds write vulnerability in Snappy.compress()
Vulnerability Details
Type: Out-of-Bounds Write (CWE-787)
CVSS 3.1: 5.9 (Medium)
Affected versions: 1.1.10.8 and earlier
Root Cause
The
compress(ByteBuffer, ByteBuffer)method never validates that thedestination ByteBuffer has sufficient capacity before calling the native
rawCompressfunction, allowing off-heap out-of-bounds writes.Fix
Added capacity check before native call:
maxCompressedLength()IllegalArgumentExceptionif insufficient spaceTesting
testCompressWithInsufficientBuffer()Impact