Conversation
The six typed uncompress*Array methods size the result array by integer-dividing the declared uncompressed byte length by the element size, then pass the undivided length to native rawUncompress. When the declared length is not a multiple of the element size, the array is under-allocated by up to (elementSize - 1) bytes while native writes the full amount: heap buffer overflow. Reject non-multiple lengths with IOException before allocation. Fixes xerial#729
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729.
Root cause. The six typed uncompress{Char,Short,Int,Long,Float,Double}Array methods size the result array by integer-dividing the declared uncompressed byte length by the element size, then pass the undivided length to native rawUncompress. When the declared length is not an exact multiple of the element size, Java under-allocates the array by 1 to elementSize-1 bytes while native code writes the full amount — heap buffer overflow past the array's backing storage (CWE-787).
Fix. Reject a declared uncompressed length that is not a multiple of the target element size with IOException before allocation. Legitimate input (from compress*Array on whole typed elements) always has a multiple-of-element-size length, so valid usage is unaffected.
Note. Distinct from CVE-2023-34453/34454/34455 (shuffle/compress integer overflows), CVE-2023-43642 (chunk-length bound in SnappyInputStream), and the compress bounds check in PR #733 (issue #732).
Disclosure: developed with AI assistance.