Skip to content

ListArray::reset_offsets doesn't need to revalidate array after reset #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robert3005 merged 2 commits into from
Jul 16, 2026
Merged

ListArray::reset_offsets doesn't need to revalidate array after reset #8781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23aacb4
ListArray::reset_offsets doesn't need to revalidate array after reset
robert3005 Jul 16, 2026
676c05b
Update array.rs
robert3005 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vortex-array/src/arrays/list/array.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ use crate::array::child_to_validity;
use crate::array::validity_to_child;
use crate::arrays::ConstantArray;
use crate::arrays::List;
use crate::arrays::ListArray;
use crate::arrays::Primitive;
use crate::builtins::ArrayBuiltins;
use crate::dtype::DType;
Expand Down Expand Up @@ -338,7 +339,6 @@ pub trait ListArrayExt: TypedArrayRef<List> {
let mut elements = self.sliced_elements()?;
if recurse && elements.is_canonical() {
let compacted = elements
.clone()
.execute::<Canonical>(ctx)?
Comment thread
robert3005 marked this conversation as resolved.
.compact(ctx)?
.into_array();
Expand All @@ -357,7 +357,8 @@ pub trait ListArrayExt: TypedArrayRef<List> {
Operator::Sub,
)?;

Array::<List>::try_new(elements, adjusted_offsets, self.list_validity())
// SAFETY: By resetting the offsets we simply "shift" everything left and discard trailing garbage, so all invariants remain the same.
Ok(unsafe { ListArray::new_unchecked(elements, adjusted_offsets, self.list_validity()) })
Comment thread
robert3005 marked this conversation as resolved.
}
}
impl<T: TypedArrayRef<List>> ListArrayExt for T {}
Expand Down
Loading