Revert "Add extension constant pushdown rule and fix InnerProduct rule"#7520
Revert "Add extension constant pushdown rule and fix InnerProduct rule"#7520joseph-isaacs wants to merge 1 commit intodevelopfrom
InnerProduct rule"#7520Conversation
|
we only want to revert the rule, not the other changes |
Merging this PR will degrade performance by 23.81%
Performance Changes
Comparing Footnotes
|
Pull request was closed
Polar Signals Profiling ResultsLatest Run
Powered by Polar Signals Cloud |
Benchmarks: PolarSignals ProfilingVortex (geomean): 0.937x ➖ datafusion / vortex-file-compressed (0.937x ➖, 1↑ 0↓)
|
File Sizes: PolarSignals ProfilingNo file size changes detected. |
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.995x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.001x ➖, 0↑ 0↓)
datafusion / parquet (1.026x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.015x ➖, 0↑ 2↓)
duckdb / vortex-compact (1.004x ➖, 1↑ 0↓)
duckdb / parquet (1.048x ➖, 0↑ 1↓)
Full attributed analysis
|
File Sizes: FineWeb NVMeNo file size changes detected. |
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.043x ➖, 0↑ 1↓)
datafusion / vortex-compact (1.047x ➖, 0↑ 0↓)
datafusion / parquet (1.042x ➖, 2↑ 5↓)
datafusion / arrow (1.099x ➖, 0↑ 10↓)
duckdb / vortex-file-compressed (1.049x ➖, 0↑ 2↓)
duckdb / vortex-compact (1.053x ➖, 0↑ 2↓)
duckdb / parquet (0.994x ➖, 1↑ 0↓)
duckdb / duckdb (1.013x ➖, 0↑ 0↓)
Full attributed analysis
|
File Sizes: TPC-H SF=1 on NVMENo file size changes detected. |
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.816x ✅, 90↑ 0↓)
datafusion / vortex-compact (0.835x ✅, 77↑ 0↓)
datafusion / parquet (0.866x ✅, 72↑ 0↓)
duckdb / vortex-file-compressed (0.918x ➖, 37↑ 9↓)
duckdb / vortex-compact (1.037x ➖, 17↑ 38↓)
duckdb / parquet (0.896x ✅, 42↑ 0↓)
duckdb / duckdb (0.906x ➖, 38↑ 0↓)
Full attributed analysis
|
File Sizes: TPC-DS SF=1 on NVMENo file size changes detected. |
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.924x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.875x ➖, 1↑ 0↓)
datafusion / parquet (1.123x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.072x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.064x ➖, 0↑ 1↓)
duckdb / parquet (1.009x ➖, 0↑ 0↓)
Full attributed analysis
|
Benchmarks: Random AccessVortex (geomean): 0.901x ➖ unknown / unknown (1.004x ➖, 6↑ 8↓)
|
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.007x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.003x ➖, 0↑ 0↓)
duckdb / parquet (0.987x ➖, 0↑ 0↓)
Full attributed analysis
|
File Sizes: Statistical and Population GeneticsNo file size changes detected. |
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.003x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.997x ➖, 0↑ 0↓)
datafusion / parquet (1.003x ➖, 0↑ 0↓)
datafusion / arrow (1.002x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.006x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.000x ➖, 0↑ 0↓)
duckdb / parquet (0.999x ➖, 0↑ 0↓)
duckdb / duckdb (0.998x ➖, 0↑ 0↓)
Full attributed analysis
|
File Sizes: TPC-H SF=10 on NVMENo file size changes detected. |
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.019x ➖, 0↑ 1↓)
datafusion / parquet (1.020x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.007x ➖, 2↑ 0↓)
duckdb / parquet (1.009x ➖, 0↑ 1↓)
duckdb / duckdb (0.956x ➖, 5↑ 1↓)
Full attributed analysis
|
File Sizes: Clickbench on NVMEFile Size Changes (1 files changed, -0.0% overall, 0↑ 1↓)
Totals:
|
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.994x ➖, 1↑ 2↓)
datafusion / vortex-compact (0.955x ➖, 1↑ 2↓)
datafusion / parquet (1.063x ➖, 0↑ 1↓)
duckdb / vortex-file-compressed (1.043x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.079x ➖, 0↑ 1↓)
duckdb / parquet (1.040x ➖, 0↑ 1↓)
Full attributed analysis
|
Benchmarks: CompressionVortex (geomean): 1.004x ➖ unknown / unknown (1.000x ➖, 0↑ 1↓)
|
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.026x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.965x ➖, 2↑ 2↓)
datafusion / parquet (0.910x ➖, 3↑ 1↓)
duckdb / vortex-file-compressed (1.048x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.063x ➖, 0↑ 0↓)
duckdb / parquet (1.089x ➖, 0↑ 0↓)
Full attributed analysis
|
Reverts #7507