Skip to content

Faster importedModulesResolved - #2858

Merged
sungshik merged 2 commits into
performance-improvements-mainfrom
performance-improvements/faster-importedmodulesresolved
Aug 19, 2026
Merged

Faster importedModulesResolved#2858
sungshik merged 2 commits into
performance-improvements-mainfrom
performance-improvements/faster-importedmodulesresolved

Conversation

@sungshik

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (d2ce976) to head (b963bcb).

Files with missing lines Patch % Lines
...g/rascalmpl/interpreter/env/ModuleEnvironment.java 85% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@                       Coverage Diff                       @@
##             performance-improvements-main   #2858   +/-   ##
===============================================================
  Coverage                               45%     46%           
- Complexity                            6770    6772    +2     
===============================================================
  Files                                  844     844           
  Lines                                67136   67143    +7     
  Branches                             10025   10026    +1     
===============================================================
+ Hits                                 30879   30892   +13     
- Misses                               33877   33878    +1     
+ Partials                              2380    2373    -7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman DavyLandman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @jurgenvinju do you agree?

Comment thread src/org/rascalmpl/interpreter/env/ModuleEnvironment.java Outdated
@sungshik
sungshik force-pushed the performance-improvements/faster-importedmodulesresolved branch 2 times, most recently from 9264825 to ecaef2e Compare August 18, 2026 13:56
Comment thread src/org/rascalmpl/interpreter/env/ModuleEnvironment.java
@sungshik
sungshik marked this pull request as ready for review August 18, 2026 14:23

@PaulKlint PaulKlint left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that @jurgenvinju or @DavyLandman review this.

@sungshik
sungshik force-pushed the performance-improvements-main branch from ee6fe45 to d2ce976 Compare August 19, 2026 11:45
@sungshik
sungshik force-pushed the performance-improvements/faster-importedmodulesresolved branch from ee34874 to b963bcb Compare August 19, 2026 11:56
@sonarqubecloud

Copy link
Copy Markdown

@jurgenvinju jurgenvinju left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope it helps!

@sungshik
sungshik merged commit f857c16 into performance-improvements-main Aug 19, 2026
9 checks passed
@sungshik
sungshik deleted the performance-improvements/faster-importedmodulesresolved branch August 19, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants