Faster doSaveModule - #2833
Open
sungshik wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## performance-improvements-main #2833 +/- ##
===============================================================
- Coverage 45% 45% -1%
+ Complexity 6722 6719 -3
===============================================================
Files 841 841
Lines 67060 67060
Branches 10016 10016
===============================================================
- Hits 30790 30778 -12
- Misses 33886 33895 +9
- Partials 2384 2387 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sungshik
force-pushed
the
performance-improvements/faster-dosavemodule
branch
3 times, most recently
from
August 4, 2026 11:44
1531f00 to
880892c
Compare
sungshik
force-pushed
the
performance-improvements-main
branch
from
August 17, 2026 12:59
7801b9c to
ebf322d
Compare
sungshik
force-pushed
the
performance-improvements/faster-dosavemodule
branch
from
August 17, 2026 13:15
880892c to
c06368f
Compare
|
sungshik
commented
Aug 17, 2026
sungshik
left a comment
sungshik
left a comment
Contributor
Author
There was a problem hiding this comment.
A few clarifying comments
| ms.messages[currentModule] = toSet(m1.messages); | ||
|
|
||
| filteredModuleScopePaths = {ml.path |loc ml <- filteredModuleScopes}; | ||
| // filteredModuleScopePaths = {ml.path |loc ml <- filteredModuleScopes}; |
Contributor
Author
There was a problem hiding this comment.
Variable filteredModuleScopePaths is unused. I am keeping it as a comment, instead of removing it, because there are other commented lines in this function that use that variable.
|
|
||
| m1.definitions = ( def.defined : def | Define def <- m1.defines); // TODO this is derived info, can we derive it later? | ||
| // Remove default expressions and fragments | ||
| // (Relatively expensive: can take >50% of the execution time of this function) |
Contributor
Author
There was a problem hiding this comment.
Adding this comment here as a reminder that this piece of code might be, or not, amenable to further optimization.
2 tasks
sungshik
marked this pull request as ready for review
August 18, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.