Skip to content

Remove use of warnings.warn #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timothy-nunn merged 3 commits into from
Jul 3, 2026
Merged

Remove use of warnings.warn #4407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fa76598
warn to logger warning
je-cook Jul 2, 2026
fb7c916
linter fixes
je-cook Jul 2, 2026
2a3b456
Apply suggestions from code review
je-cook Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions process/core/caller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
from __future__ import annotations

import logging
import warnings
from typing import TYPE_CHECKING

import numpy as np
Expand Down Expand Up @@ -223,7 +222,7 @@ def call_models_and_write_output(self, xc: np.ndarray, ifail: int):
headers=["Variable", "Previous value", "Current value"],
)

warnings.warn(
logger.warning(
f"\033[93m{non_idempotent_warning}\n{non_idempotent_table}\033[0m",
stacklevel=2,
)
Expand Down Expand Up @@ -367,7 +366,8 @@ def _call_models_once(self, xc: np.ndarray):
# Buildings model
self.models.buildings.run()

# These two methods need to be run after vacuum/buildings otherwise output changes quite a lot
# These two methods need to be run after vacuum/buildings otherwise
# output changes quite a lot
# TODO: split these two sections into a new model with a .run method
# Plant AC power requirements
self.models.power.acpow(output=False)
Expand Down
Loading
Loading