Skip to content

Remove use of warnings.warn#4407

Merged
timothy-nunn merged 3 commits into
ukaea:mainfrom
je-cook:no_warnings
Jul 3, 2026
Merged

Remove use of warnings.warn#4407
timothy-nunn merged 3 commits into
ukaea:mainfrom
je-cook:no_warnings

Conversation

@je-cook

@je-cook je-cook commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

Description

Closes #4402

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

@je-cook je-cook requested a review from a team as a code owner July 2, 2026 14:21
@codecov-commenter

codecov-commenter commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 42.30769% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.83%. Comparing base (024a2f2) to head (2a3b456).

Files with missing lines Patch % Lines
process/core/init.py 33.33% 10 Missing ⚠️
process/core/caller.py 0.00% 1 Missing ⚠️
process/core/input.py 66.66% 1 Missing ⚠️
process/core/io/plot/solutions.py 0.00% 1 Missing ⚠️
process/core/solver/iteration_variables.py 66.66% 1 Missing ⚠️
process/models/tfcoil/quench.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4407   +/-   ##
=======================================
  Coverage   48.83%   48.83%           
=======================================
  Files         151      151           
  Lines       29397    29397           
=======================================
  Hits        14356    14356           
  Misses      15041    15041           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread process/core/solver/iteration_variables.py Outdated
Comment thread process/core/init.py Outdated
Comment thread process/core/init.py Outdated
Comment thread process/core/init.py Outdated
Co-authored-by: je-cook <81617086+je-cook@users.noreply.github.com>
@je-cook je-cook requested a review from timothy-nunn July 2, 2026 14:58
@timothy-nunn timothy-nunn merged commit 699eb86 into ukaea:main Jul 3, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove use of warn in PROCESS models

3 participants