Reproduce stale circuit JSON after a failed rebuild - #4394
Open
ShiboSoftwareDev wants to merge 1 commit into
Open
Reproduce stale circuit JSON after a failed rebuild#4394ShiboSoftwareDev wants to merge 1 commit into
ShiboSoftwareDev wants to merge 1 commit into
Conversation
ShiboSoftwareDev
marked this pull request as ready for review
August 20, 2026 23:40
Contributor
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reproduction
This adds a focused integration test that:
index.tsxand savesdist/index/circuit.jsoncircuit.jsonis still present byte-for-byteThe stale artifact can therefore look like the failed source revision built successfully to downstream fabrication or inspection tooling.
Expected behavior
A failed rebuild must not leave the prior
circuit.jsonat the output path for that entrypoint.Actual behavior
The fatal build exits 1, but
dist/index/circuit.jsonstill contains the previous successful build.Test
bun test tests/cli/build/build-failed-rebuild-stale-output.test.tsbun run format:checkThis is the reproduction PR. The fix is intentionally kept in the next PR in the stack.