Skip to content

Remove stale circuit JSON before rebuilding - #4395

Closed
ShiboSoftwareDev wants to merge 1 commit into
repro/failed-build-keeps-stale-circuit-jsonfrom
fix/remove-stale-circuit-json-on-build-start
Closed

Remove stale circuit JSON before rebuilding#4395
ShiboSoftwareDev wants to merge 1 commit into
repro/failed-build-keeps-stale-circuit-jsonfrom
fix/remove-stale-circuit-json-on-build-start

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

Summary

  • remove an entrypoint's existing circuit.json before circuit generation starts
  • apply the same behavior to sequential builds and concurrent worker builds
  • preserve the source when a prebuilt Circuit JSON path is also the output path
  • turn the reproduction into a regression test that requires the stale artifact to be absent after a fatal rebuild

Stack

This branch is based directly on the reproduction branch so GitHub can show the stack.

Tests

  • bun test tests/cli/build/build-failed-rebuild-stale-output.test.ts
  • bun run format:check
  • bun run build

@ShiboSoftwareDev
ShiboSoftwareDev marked this pull request as ready for review August 20, 2026 23:40
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions

Copy link
Copy Markdown
Contributor

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions Bot closed this Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant