Skip to content

Reproduce build succeeding with DRC errors - #4389

Open
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
repro/build-drc-errors-exit-zero
Open

Reproduce build succeeding with DRC errors#4389
ShiboSoftwareDev wants to merge 1 commit into
mainfrom
repro/build-drc-errors-exit-zero

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

Problem

tsci build writes Circuit JSON containing DRC errors, prints Build completed with errors, and still exits with status 0. A fabrication or CI script therefore cannot distinguish a clean build from a board with reported errors.

Reproduction

The focused CLI test builds a real board with a resistor outside the board boundary. It verifies that the generated Circuit JSON contains the corresponding pcb_component_outside_board_error and records the current contradiction:

  • the default command prints Build completed with errors
  • the default command exits 0
  • --ignore-errors also exits 0

The reproduction changes no CLI implementation.

Expected behavior

The default command should exit nonzero when unignored DRC errors are present. --ignore-errors should remain the explicit opt-in for a successful exit.

Verification

  • bun test tests/cli/build/build-with-drc-error.test.ts
  • bun run format:check

The fix will be proposed as a separate PR stacked on this branch.

@ShiboSoftwareDev
ShiboSoftwareDev marked this pull request as ready for review August 20, 2026 23:39
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant