Skip to content

Fail builds with unignored circuit errors - #4390

Open
ShiboSoftwareDev wants to merge 1 commit into
repro/build-drc-errors-exit-zerofrom
fix/build-drc-errors-exit-nonzero
Open

Fail builds with unignored circuit errors#4390
ShiboSoftwareDev wants to merge 1 commit into
repro/build-drc-errors-exit-zerofrom
fix/build-drc-errors-exit-nonzero

Conversation

@ShiboSoftwareDev

Copy link
Copy Markdown
Contributor

Stack

Review and merge the reproduction first: #4389

This branch is based directly on the reproduction branch, so the PR diff contains only the behavior change and corrected expectations.

Fix

  • exit with status 1 when Circuit JSON contains unignored errors
  • retain status 1 for fatal generation failures
  • retain status 0 when --ignore-errors explicitly suppresses the errors
  • retain category-specific ignore behavior: a build only succeeds when every remaining error category is ignored
  • report whether the nonzero exit came from a fatal generation failure or unignored circuit errors

Observable result

Command Reproduction Fix
tsci build with DRC errors 0 1
tsci build --ignore-errors 0 0

Verification

  • bun test tests/cli/build/build-with-drc-error.test.ts tests/cli/build/build-ignore-drc-categories.test.ts tests/cli/build/build-fail-fast.test.ts
  • bun run format:check
  • bun run build

@ShiboSoftwareDev
ShiboSoftwareDev marked this pull request as ready for review August 20, 2026 23:39
@github-actions

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant