Skip to content

test(core/030): retry connect to kill status=0 flake (#48) #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
EdmondDantes merged 1 commit into from
May 29, 2026
+10 −1
Merged

test(core/030): retry connect to kill status=0 flake (#48) #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/phpt/server/core/030-response-json.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,16 @@ $server->addHttpHandler(function ($req, $resp) {
});

function fetch(int $port, string $path): array {
$fp = stream_socket_client("tcp://127.0.0.1:$port", $errno, $errstr, 2);
/* Retry the connect a few times: under parallel run-tests load the
* first attempt can transiently fail before the accept loop picks it
* up, otherwise showing up as a flaky status=0. The JSON response
* semantics under test are unaffected. */
$fp = false;
for ($try = 0; $try < 20 && $fp === false; $try++) {
$fp = @stream_socket_client("tcp://127.0.0.1:$port", $errno, $errstr, 2);
if ($fp === false) { usleep(10000); }
}
if ($fp === false) { return [0, [], '']; }
stream_set_timeout($fp, 2);
fwrite($fp, "GET $path HTTP/1.1\r\nHost: x\r\nConnection: close\r\n\r\n");
$raw = '';
Expand Down
Loading