test(core/030): retry connect to kill status=0 flake (#48)#56
Merged
Conversation
030's fetch() didn't guard stream_socket_client returning false, so a transient connect failure under parallel run-tests load (the first attempt racing the accept loop) surfaced as a flaky status=0 — seen on main CI. Retry the connect up to 20×10ms and return a clean [0,[],''] if it never succeeds. Test semantics (JSON response behaviour) unchanged; 5/5 stable locally.
Contributor
CoverageTotal lines: 80.80% → 80.66% (-0.14 pp)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
core/030-response-jsonflaked on main CI withstatus=0for some sub-requests:fetch()didn't guardstream_socket_clientreturningfalse, so a transient connect failure under parallelrun-tests -jload (first attempt racing the accept loop) produced empty reads → status 0.Fix: retry the connect up to 20×10 ms and return a clean
[0,[],'']on total failure. The JSON response semantics under test are unchanged. 5/5 stable locally. Tracked under #48.