feat(acl): add autoApprovers and ACL tests to visual editor#550
Open
feat(acl): add autoApprovers and ACL tests to visual editor#550
Conversation
Add comment-json dependency for parsing HuJSON (JSON with comments and trailing commas) used by Headscale ACL policies. Introduces app/utils/acl-editor.ts with typed interfaces for ACL policy entities and pure functions for parsing, serializing, and mutating policy sections (rules, groups, hosts, tags, SSH rules). Comment metadata is preserved through mutations via comment-json's assign helper. Includes 45 unit tests covering parsing, round-trips, comment preservation, trailing comma handling, and all mutation functions.
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the visual ACL editor for #286. Depends on #548 and #549.
Thanks to @simone-gasparini for the groundwork in #404 that helped shape this approach.
What this adds
Extends the visual editor with the two remaining policy sections:
RecordSection<string[]>for managing CIDR-to-approvers mappingsRecordSection<string[]>with a fixed key, reusing the same generic componentArraySection<AclTest>with optional accept/deny destination fieldsAlso includes cleanup from #549: extracted
KeyListRowto share the repeated key+tags layout across Groups, Tag Owners, and Routes. Dialog titles now derive from the sectiontitleprop.acl-editor.ts
AclTesttype replacesunknown[]for thetestsfieldroutes/exitNodestructureTests
3 new tests covering autoApprover independence, empty-policy safety, and ACL test CRUD. 34 total.