feat(acl): visual editor UI with generic section components#549
Open
feat(acl): visual editor UI with generic section components#549
Conversation
Contributor
Author
|
Add comment-json dependency for parsing HuJSON (JSON with comments and trailing commas) used by Headscale ACL policies. Introduces app/utils/acl-editor.ts with typed interfaces for ACL policy entities and pure functions for parsing, serializing, and mutating policy sections (rules, groups, hosts, tags, SSH rules). Comment metadata is preserved through mutations via comment-json's assign helper. Includes 45 unit tests covering parsing, round-trips, comment preservation, trailing comma handling, and all mutation functions.
drifterza
force-pushed
the
feat/acl-visual-editor
branch
from
c22540b to
d0b6e26
Compare
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #548 and adds the interactive visual editor as a new tab on the ACL page.
Two generic components —
ArraySection<T>andRecordSection<V>— handle all shared CRUD mechanics (add/edit/remove dialogs, list rendering). Five section instances built on top: ACL Rules, Groups, Hosts, Tag Owners, SSH Rules.Edits stay in-memory and sync with the code editor tab. Nothing is saved to Headscale until the user clicks "Save". Record renames use remove+set to keep logic simple.
comment-jsonassign()preserves HuJSON comment metadata throughout.Also fixed a pre-existing type error in
tests/integration/api/nodes.test.ts.PR 2 of 3 for the visual ACL editor (#286):
Thanks to @simone-gasparini for the initial work in #404.