Skip to content

Chore: shell quote critical fix #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SbsCruz merged 4 commits into from
Sep 16, 2026
Merged

Chore: shell quote critical fix #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c6973a0
chore: upgrade react-native and related packages to newer versions
SbsCruz Sep 1, 2026
3b087b8
chore: disable sonarjs/deprecation for react-test-renderer usage
SbsCruz Sep 2, 2026
d158a9a
chore: upgrade react-dom to match react v19.2.3
SbsCruz Sep 2, 2026
d37fb85
chore: upgrade react-native-testing-mocks to v1.7.0 to support RN@^0.…
SbsCruz Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ export default defineConfig(
"react/jsx-no-literals": "error",
"react/prop-types": "off",
"sonarjs/cognitive-complexity": "off",
"sonarjs/deprecation": "off",

@suany0805 suany0805 Sep 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we setting off this one rule

@SbsCruz SbsCruz Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quoting the first comment of this PR:

It also disables sonarjs/deprecation as react-test-renderer (and its ReactTestInstance type) is deprecated in favor of HostElement, but that type is only available starting in @testing-library/react-native v14. This project currently uses 12.9.0, so HostElement isn't available yet.

Upgrading to v14 is a breaking change on its own (async render/fireEvent/act/renderHook) and needs to be scoped as its own migration

"sonarjs/different-types-comparison": "off",
"sonarjs/function-return-type": "off",
"sonarjs/no-duplicate-string": "off",
Expand Down
9 changes: 9 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,14 @@
},
"devDependencies": {
"@eslint/js": "^9.39.1",
"@react-native-community/cli": "20.1.0",
"@react-native-community/cli-platform-android": "20.1.0",
"@react-native-community/cli-platform-ios": "20.1.0",
"@react-native/babel-preset": "0.84.0",
"@react-native/eslint-config": "0.84.0",
"@react-native/metro-config": "0.84.0",
"@react-native/new-app-screen": "0.84.0",
"@react-native/typescript-config": "0.84.0",
"@stylistic/eslint-plugin": "^5.6.1",
"eslint": "^9.39.1",
"eslint-import-resolver-typescript": "^4.4.4",
Expand All @@ -38,6 +46,7 @@
"eslint-plugin-react": "^7.37.5",
"eslint-plugin-sonarjs": "^3.0.5",
"globals": "^16.5.0",
"react-native-safe-area-context": "^5.5.2",
"rimraf": "^6.1.2",
"turbo": "^1.12.4",
"typescript": "^5.9.3",
Expand Down
10 changes: 5 additions & 5 deletions packages/dom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,15 @@
"@types/jsdom-global": "^3",
"@types/mocha": "^10.0.6",
"@types/node": "^24.10.1",
"@types/react": "^18.3.3",
"@types/react": "^19.2.0",
"@types/react-dom": "^18.3.0",
"@types/react-test-renderer": "^18",
"@types/react-test-renderer": "^19.1.0",
"jsdom": "^24.0.0",
"jsdom-global": "^3.0.2",
"mocha": "^11.8.0",
"react": "^18.3.1",
"react-dom": "^18.3.1",
"react-test-renderer": "^18.3.1",
"react": "19.2.3",
"react-dom": "19.2.3",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release-yarn": "^3.0.2",
"ts-node": "^10.9.2",
Expand Down
12 changes: 6 additions & 6 deletions packages/native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@
"@testing-library/react-native": "^12.9.0",
"@types/mocha": "^10.0.6",
"@types/node": "^24.10.1",
"@types/react": "^18.2.70",
"@types/react-test-renderer": "^18.0.7",
"@types/react": "^19.2.0",
"@types/react-test-renderer": "^19.1.0",
"@types/sinon": "^17.0.3",
"mocha": "^11.8.0",
"react": "^18.2.0",
"react-native": "^0.73.6",
"react-native-testing-mocks": "^1.2.0",
"react-test-renderer": "^18.2.0",
"react": "19.2.3",
"react-native": "0.84.0",
"react-native-testing-mocks": "^1.7.0",
"react-test-renderer": "19.2.3",
"semantic-release": "^23.1.1",
"semantic-release-yarn": "^3.0.2",
"sinon": "^17.0.1",
Expand Down
Loading
Loading