Chore: shell quote critical fix - #178
Merged
Merged
Conversation
suany0805
approved these changes
Sep 16, 2026
suany0805
reviewed
Sep 16, 2026
| "react/jsx-no-literals": "error", | ||
| "react/prop-types": "off", | ||
| "sonarjs/cognitive-complexity": "off", | ||
| "sonarjs/deprecation": "off", |
Contributor
There was a problem hiding this comment.
why are we setting off this one rule
Contributor
Author
There was a problem hiding this comment.
Quoting the first comment of this PR:
It also disables
sonarjs/deprecationasreact-test-renderer(and its ReactTestInstance type) is deprecated in favor ofHostElement, but that type is only available starting in@testing-library/react-native v14. This project currently uses12.9.0, so HostElement isn't available yet.Upgrading to
v14is a breaking change on its own (async render/fireEvent/act/renderHook) and needs to be scoped as its own migration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the critical issue #119 by upgrading the following dependencies:
19.2.30.84.0react-native-testing-mocksto1.7.0It also disables
sonarjs/deprecationasreact-test-renderer(and its ReactTestInstance type) is deprecated in favor ofHostElement, but that type is only available starting in@testing-library/react-native v14. This project currently uses12.9.0, so HostElement isn't available yet.Upgrading to
v14is a breaking change on its own (async render/fireEvent/act/renderHook) and needs to be scoped as its own migration