fix(vector): Use relative path to patchable checked out source#1471
Open
NickLarsenNZ wants to merge 3 commits intomainfrom
Open
fix(vector): Use relative path to patchable checked out source#1471NickLarsenNZ wants to merge 3 commits intomainfrom
NickLarsenNZ wants to merge 3 commits intomainfrom
Conversation
Fixes this error: ``` find: '/src/': No such file or directory ``` Because fot this build, WORKDIR is /stackable (so patchable checked out src/ is below that)
dervoeti
moved this from Development: Waiting for Review
to Development: In Review
in Stackable Engineering
dervoeti
requested changes
Apr 17, 2026
| # assuming WORKDIR was `/stackable`. | ||
| base=$(basename "$1") | ||
| find /src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \; | ||
| find ./src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \; |
Member
There was a problem hiding this comment.
Suggested change
| find ./src/ -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \; | |
| find . -maxdepth 1 -type f -name "${base}_bin.cdx.xml" -exec cp {} /app \; |
Member
Author
There was a problem hiding this comment.
I'm unsure if you tested it or not, but I now don't have time (due to other tasks) so I would go with what I have since it worked (it is gated by the exact match for ${base}_bin.cdx.xml).
I'm happy to come back and fix it if you see an issue - just not sure if this was more stylistic or an actual problem you discovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this error:
Because for this (vector) build, WORKDIR is /stackable (so patchable checked out src/ is below that)