Repository navigation
fix: type-check star-sourced columns without full requalification - #28
Merged
Merged
Conversation
Validation previously requalified the whole statement only when it contained both a set operation and a star. That was expensive for large set-operation projects and left identical queries without a set operation unchecked for star-sourced column types. Expand CTE and source stars with the ordered lineage expansion for every statement with a projection star, and fall back to full qualification only when a star remains unresolved (for example over a derived table). Bump the version to 0.13.5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Type validation requalified the whole statement only when it contained both a set operation and a star. That second qualification dominated validation time on large set-operation projects, and identical queries without a set operation got no star-sourced column types, so their type conflicts were silently unchecked.
Changes
Verification
cargo test --lib -p polyglot-sql: 1340 passed.