Repository navigation
perf: skip requalification for stars no scope consumes - #29
Merged
Merged
Conversation
Validation fell back to whole-statement qualification whenever a star remained after ordered CTE expansion, including a star in the root SELECT's own projection. That star feeds no expression in the statement, so type checks never need its expansion. Only fall back for unresolved stars read by an outer scope or a set operation. Bump to 0.13.6.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
After #28, validation still fell back to whole-statement qualification whenever a star remained after ordered CTE expansion, including a star in the root SELECT's own projection (for example
SELECT * FROM (SELECT ...) AS nested). That star feeds no expression in the statement, so the fallback cost qualification time without adding any type check.Changes
Verification
cargo test --lib -p polyglot-sql: 1340 passed;make test-rust-feature-gatespassed.