ISC26: update the basics section#535
Merged
Merged
Conversation
This is so that audience is already aware of where we are headin into, when we introduce the various pieces (hash, store, etc.).
Also, consolidate all the use of `spack find`
haampie
pushed a commit
to spack/spack-packages
that referenced
this pull request
Jun 17, 2026
This follows from spack/spack-tutorial#535 Signed-off-by: Massimiliano Culpo <massimiliano.culpo@gmail.com>
kshea21
reviewed
Jun 19, 2026
kshea21
left a comment
kshea21
left a comment
Collaborator
There was a problem hiding this comment.
Overall I really like what you did with this section! I just left some comments on language preferences, but nothing stood out that needs to change conceptually.
| A Realistic Example | ||
| ------------------- | ||
|
|
||
| Now that we know the spec syntax and how to query installations, let's put them to work on a realistic package. |
Collaborator
There was a problem hiding this comment.
Maybe knit-picking, but I don't think I like the term "realistic" here, all of the other examples were realistic installations someone could do as well
Member
There was a problem hiding this comment.
@kshea21 is on vacation today. Edits look good to me.
Member
Author
|
Thanks for the review @kshea21 ! I addressed the comments and went ahead closing the ones I "just accepted". |
This was referenced Jun 19, 2026
Signed-off-by: Alec Scott <alec@llnl.gov>
Signed-off-by: Alec Scott <alec@llnl.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This section has been reorganized, so that concepts are introduced in order rather than interleaved.
Structural changes:
spack help --specis the last subsection herespack findto avoid back and forthspack findusage (including the former "Advanced spack find Usage") in one place.Content changes:
cflags=but shows+ipoandbuild_type=Debuginstead in the Variants subsection.mpi@3).spack graphfor trilinos.The output was generated using:
(see #536 for how that image was built) and editing the Makefile locally to point to that container image.