[Type] Introduce clamped scalar ensuring value not outside bounds - #6209
Open
alxbilger wants to merge 1 commit into
Open
[Type] Introduce clamped scalar ensuring value not outside bounds#6209alxbilger wants to merge 1 commit into
alxbilger wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new foundational type, sofa::type::ClampedScalar. This class template wraps a standard scalar value and guarantees that the stored value cannot fall outside predefined minimum and maximum bounds (min/max).
Key Changes & Implementation Details
New Type (
ClampedScalar):operator=): Any attempt to set the value uses clamping, ensuring state integrity.>>) reads a raw value and clamps it before updating the internal state. Stream insertion (<<) only outputs the valid, clamped value.calculateClamped(T rawValue)method allows users to predict what the bound-constrained result would be without modifying the object's actual state.Integration into
VisualMeshComponent:d_elementSpacedata member insofa::component::visual::VisualMeshhas been updated fromData<SReal>toData<type::ClampedScalar<SReal>>.Framework Updates:
ClampedScalar.h,ClampedScalar.cpp, and corresponding test files (ClampedScalar_test.cpp) toSofa/framework/Type.VisualMesh.Companion PR for the GUI: sofa-framework/SofaGLFW#292
clamped.mp4
Local gemma-4-e4b used for documentation and unit tests.
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if