Skip to content

[LinearSystem] Fix CompositeLinearSystem not invalidating its matrix#6202

Open
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:fixcomposite
Open

[LinearSystem] Fix CompositeLinearSystem not invalidating its matrix#6202
alxbilger wants to merge 3 commits into
sofa-framework:masterfrom
alxbilger:fixcomposite

Conversation

@alxbilger

@alxbilger alxbilger commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

CompositeLinearSystem never invalidates its matrix, hence it is never inverted. In this PR, the invalidation of the matrix is linked to the invalidation of the matrix used by the linear solver.

Probably broken since 60d44cf indicating a lack of tests.

[with-all-tests]

[ci-depends-on https://github.com/sofa-framework/Regression/pull/119]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@alxbilger alxbilger added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 24, 2026
@alxbilger alxbilger removed the pr: fast merge Minor change that can be merged without waiting for the 7 review days label Jul 24, 2026
@sofabot

sofabot commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

[ci-depends-on] detected during build #2.

To unlock the merge button, you must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants