Create changeset to removepool from tar solana#22272
Create changeset to removepool from tar solana#22272agusaldasoro wants to merge 3 commits intodevelopfrom
Conversation
agusaldasoro
requested review from
AmrMohamedRezk,
KodeyThomas,
asoliman92,
carte7000,
chris-de-leon-cll,
tt-cll and
winder
|
👋 agusaldasoro, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
Pull request overview
Adds a new Solana v0.1.1 deployments-framework changeset to remove (unset) the token pool association in the Token Admin Registry, supporting LINK-777.
Changes:
- Register a new
RemovePoolchangeset in the Solana v0.1.1 token admin registry changeset package. - Introduce
RemovePoolConfigvalidation and execution logic that clears the registry’s lookup table by setting it to the default pubkey. - Add MCMS/timelock proposal path support when the registry admin is the timelock signer PDA.
| zeroAddress, | ||
| currentAdmin, | ||
| ) | ||
| base.AccountMetaSlice = append(base.AccountMetaSlice, solana.Meta(zeroAddress)) |
| // RemovePool sets the token pool lookup table to the zero address, effectively removing the pool association. | ||
| func RemovePool(e cldf.Environment, cfg RemovePoolConfig) (cldf.ChangesetOutput, error) { | ||
| e.Logger.Infow("Removing pool config", "cfg", cfg) | ||
| state, err := stateview.LoadOnchainState(e) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
| // remote chain setup | ||
| func TestAddRemoteChainWithMcms(t *testing.T) { | ||
| t.Parallel() | ||
| skipInCI(t) |
There was a problem hiding this comment.
These seem really easy to lose track of. @kalverra Do we have an idiomatic way of doing this that is not overlooked by our other flake & release tooling?
func skipInCI(t *testing.T) {
ci := os.Getenv("CI") == "true"
if ci {
t.Skip("Skipping in CI")
}
}
Requires
Supports