Skip to content

Bump chainlink-aptos for Aptos account tx window fix#22264

Merged
cawthorne merged 10 commits intodevelopfrom
feature/bump-chainlink-aptos-account-tx-window
Apr 30, 2026
Merged

Bump chainlink-aptos for Aptos account tx window fix#22264
cawthorne merged 10 commits intodevelopfrom
feature/bump-chainlink-aptos-account-tx-window

Conversation

@cawthorne
Copy link
Copy Markdown
Contributor

@cawthorne cawthorne commented Apr 30, 2026

Summary

Context

The CRE Aptos write/read roundtrip merge-queue job failed because the Aptos capability requested recent transmitter account transactions with start=nil, limit=N. The previously pinned relayer passed that shape through to the Aptos SDK, which can underflow the previous-page cursor for accounts with fewer than N transactions and issue REST calls with start=18446744073709551615.

The exposure came from the Aptos capability tx-search path switching its phase-1 probe to a bounded latest-page request (start=nil, limit=10). The relayer fix resolves that limit-only request into an explicit latest transaction window before calling the Aptos SDK.

Failing job investigated: https://github.com/smartcontractkit/chainlink/actions/runs/25151620823/job/73724531635

Why Multiple Files Changed

This PR does not change Chainlink source code. The diff is dependency metadata only.

Chainlink has multiple Go modules that either directly or indirectly pin github.com/smartcontractkit/chainlink-aptos: root, deployment, integration-tests, integration-tests/load, system-tests/lib, system-tests/tests, and core/scripts. Updating only the root module and plugin manifest would leave some CI/test paths on the old relayer version, so the module pins and sums are updated consistently.

Upstream Fix

Testing

Also includes commits from:
#22272

To unblock the failing ccip solana test.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

✅ No conflicts with other open PRs targeting develop

@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Apr 30, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@github-actions
Copy link
Copy Markdown
Contributor

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cawthorne cawthorne marked this pull request as ready for review April 30, 2026 18:01
@cawthorne cawthorne requested a review from a team as a code owner April 30, 2026 18:01
Copilot AI review requested due to automatic review settings April 30, 2026 18:01
@cawthorne cawthorne requested review from a team as code owners April 30, 2026 18:01
@cawthorne cawthorne marked this pull request as draft April 30, 2026 18:02
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Risk Rating: LOW

This PR updates Chainlink’s pinned chainlink-aptos relayer/plugin version to consume the upstream fix for limit-only Aptos account transaction queries, and aligns the corresponding Go module pins across the repo’s multi-module setup.

Changes:

  • Bump github.com/smartcontractkit/chainlink-aptos to v0.0.0-20260430175646-295a7f9a1500 across all relevant Go modules and the public plugins manifest.
  • Bump go.uber.org/zap to v1.28.0 where required by the updated dependency graph.
  • Refresh go.sum files to match the new module versions/hashes.

Areas requiring scrupulous human review:

  • Confirm the pinned chainlink-aptos pseudo-version maps to the intended upstream commit (295a7f9a1500...) referenced in the PR description and that it contains the expected fix behavior.
  • Confirm plugin installation workflows that consume plugins/plugins.public.yaml behave as expected with the updated gitRef.

Reviewed changes

Copilot reviewed 8 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Bumps root module pins for chainlink-aptos and zap.
go.sum Updates root module sums for chainlink-aptos and zap.
deployment/go.mod Aligns deployment module pins for chainlink-aptos and zap.
deployment/go.sum Updates deployment module sums for the bumped dependencies.
integration-tests/go.mod Aligns integration-tests module pins for chainlink-aptos and zap.
integration-tests/go.sum Updates integration-tests module sums for the bumped dependencies.
integration-tests/load/go.mod Aligns load-tests module pins for chainlink-aptos and zap (indirect).
integration-tests/load/go.sum Updates load-tests module sums for the bumped dependencies.
system-tests/lib/go.mod Aligns system-tests lib module pins for chainlink-aptos and zap.
system-tests/lib/go.sum Updates system-tests lib module sums for the bumped dependencies.
system-tests/tests/go.mod Aligns system-tests tests module pin for chainlink-aptos and zap (indirect).
system-tests/tests/go.sum Updates system-tests tests module sums for the bumped dependencies.
core/scripts/go.mod Aligns core/scripts module pins for chainlink-aptos (indirect) and zap.
core/scripts/go.sum Updates core/scripts module sums for the bumped dependencies.
plugins/plugins.public.yaml Updates public aptos plugin gitRef to the new chainlink-aptos pseudo-version.

@cawthorne
Copy link
Copy Markdown
Contributor Author

cawthorne commented Apr 30, 2026

Seems to be blocked by this (potentially unrelated) Solana tests:
https://github.com/smartcontractkit/chainlink/actions/runs/25181157355/job/73826561639?pr=22264

@cawthorne cawthorne marked this pull request as ready for review April 30, 2026 18:26
jmank88
jmank88 previously approved these changes Apr 30, 2026
@cawthorne cawthorne enabled auto-merge April 30, 2026 19:05
agusaldasoro and others added 3 commits April 30, 2026 20:10
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@cawthorne cawthorne requested a review from a team as a code owner April 30, 2026 19:11
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 30, 2026

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

@cl-sonarqube-production
Copy link
Copy Markdown

Quality Gate failed Quality Gate failed

Failed conditions
67.2% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube

@cawthorne cawthorne added this pull request to the merge queue Apr 30, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 30, 2026
@cawthorne cawthorne added this pull request to the merge queue Apr 30, 2026
Merged via the queue into develop with commit c80855c Apr 30, 2026
301 of 334 checks passed
@cawthorne cawthorne deleted the feature/bump-chainlink-aptos-account-tx-window branch April 30, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants