remove borsh encoder from encoder factory

[Unheilbar]

Originally, it was planned to be used by Securemint project in v1 workflows. The project never was launched making this code unused. It helps to get rid of solana dependency from core.

[github-actions]

✅ No conflicts with other open PRs targeting develop

[trunk-io]

     

View Full Report ↗︎ ⋅ Docs

[github-actions]

CORA - Pending Reviewers

All codeowners have approved! ✅

Legend: ✅ Approved | ❌ Changes Requested | 💬 Commented | 🚫 Dismissed | ⏳ Pending | ❓ Unknown

For more details, see the full review summary.

[github-actions]

I see you updated files related to core. Please run make gocs in the root directory to add a changeset as well as in the text include at least one of the following tags:

• #added For any new functionality added.
• #breaking_change For any functionality that requires manual action for the node to boot.
• #bugfix For bug fixes.
• #changed For any change to the existing functionality.
• #db_update For any feature that introduces updates to database schema.
• #deprecation_notice For any upcoming deprecation functionality.
• #internal For changesets that need to be excluded from the final changelog.
• #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
• #removed For any functionality/config that is removed.
• #updated For any functionality that is updated.
• #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

[Copilot]

Pull request overview

Risk Rating: MEDIUM

Removes the OCR3 Borsh/Solana encoder (and SecureMint aggregator wiring) from the core capabilities factories to reduce unused functionality and associated dependencies, while bumping chainlink-common to a version that matches the dependent upstream change.

Changes:

• Remove EncoderBorsh/Solana encoder support from core/capabilities.NewEncoder and adjust the encoder factory test accordingly.
• Remove secure_mint aggregator instantiation from core/capabilities.NewAggregator.
• Bump github.com/smartcontractkit/chainlink-common across multiple modules/sums and align a few submodule go directives to 1.26.2.

Reviewed changes

Copilot reviewed 17 out of 28 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
core/capabilities/encoder_factory.go	Removes Solana/Borsh encoder creation path from the encoder factory.
core/capabilities/encoder_factory_test.go	Updates unit test setup to no longer build Solana/Borsh encoder config.
core/capabilities/aggregator_factory.go	Removes SecureMint aggregator case from the aggregator factory switch.
go.mod / go.sum	Bumps chainlink-common pseudo-version and updates sums accordingly.
deployment/go.mod / deployment/go.sum	Same chainlink-common bump for deployment module.
core/scripts/go.mod / core/scripts/go.sum	Same chainlink-common bump for scripts module.
devenv/go.mod / devenv/go.sum	Same chainlink-common bump; sums updated for transitive deps.
integration-tests/go.mod / integration-tests/go.sum	Same chainlink-common bump for integration tests.
integration-tests/load/go.mod / integration-tests/load/go.sum	Same chainlink-common bump for load tests module.
system-tests/lib/go.mod / system-tests/lib/go.sum	Same chainlink-common bump for system test lib module.
system-tests/tests/go.mod / system-tests/tests/go.sum	Same chainlink-common bump for system tests module.
system-tests/tests/canaries_sentinels/.../go.mod / go.sum	Same chainlink-common bump for that submodule.
core/scripts/cre/environment/examples/.../go.mod / go.sum	Same chainlink-common bump for workflow examples.
system-tests/tests/smoke/cre/aptos/*/go.mod	Updates submodule go directive to 1.26.2.

[Copilot]

SecureMintAggregator is still defined (and its comment implies support), but NewAggregator no longer handles secure_mint and will return "not supported". This is confusing for callers and can be an unintended breaking change; either remove/deprecate the constant/comment, or keep the case and return a clearer error indicating the aggregator was removed/unsupported.

Suggested change

	return datafeeds.NewLLOAggregator(config)
	return datafeeds.NewLLOAggregator(config)
	case string(SecureMintAggregator):
	return nil, fmt.Errorf("aggregator %s has been removed and is no longer supported", name)

[mchain0]

I don't understand the dependency on the common repo - if we remove usages let's just remove them here to cut out dependency from common, not sure why we would need to even update common if it's only about removing stuff from use?

[cl-sonarqube-production]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube