rm borsh encoder#2019
Conversation
|
There was a problem hiding this comment.
Pull request overview
Removes the SecureMint datafeeds aggregator implementation (and its tests) as part of de-scoping/removing the borsh-encoder-related SecureMint path referenced by the linked Chainlink PR.
Changes:
- Delete
SecureMintAggregatorimplementation and related packing/helpers. - Delete the corresponding unit tests for SecureMint aggregation and packing.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator.go | Removes the SecureMint OCR3 datafeeds aggregator implementation and associated helpers/constants. |
| pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator_test.go | Removes the unit tests that validated SecureMint aggregation/config parsing/packing behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
I'm concerned about making breaking changes here. Even if core is the only user and updates quickly, it creates a point in time that we cannot easily move past for things like backports etc. and often breaks integration-tests in the chain repos. Could we leave it deprecated for a while? Or at least avoid break compilation?
Supports: smartcontractkit/chainlink#22269