Skip to content

rm borsh encoder#2019

Closed
Unheilbar wants to merge 2 commits into
mainfrom
cleanup_sol_encoders
Closed

rm borsh encoder#2019
Unheilbar wants to merge 2 commits into
mainfrom
cleanup_sol_encoders

Conversation

@Unheilbar
Copy link
Copy Markdown
Contributor

@Unheilbar Unheilbar commented Apr 30, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 30, 2026

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (10)

pkg/capabilities/consensus/ocr3/datafeeds (10)
  • NewSecureMintAggregator — 🗑️ Removed

  • ObsWithCtx — 🗑️ Removed

  • SecureMintAggregator — 🗑️ Removed

  • SecureMintAggregatorConfig — 🗑️ Removed

  • SolanaEncoderKey — 🗑️ Removed

  • SolAnswerOutputFieldName — 🗑️ Removed

  • SolDataIDOutputFieldName — 🗑️ Removed

  • SolTimestampOutputFieldName — 🗑️ Removed

  • TopLevelAccountCtxHashFieldName — 🗑️ Removed

  • TopLevelPayloadListFieldName — 🗑️ Removed


📄 View full apidiff report

@Unheilbar Unheilbar marked this pull request as ready for review May 1, 2026 12:55
@Unheilbar Unheilbar requested a review from a team as a code owner May 1, 2026 12:55
Copilot AI review requested due to automatic review settings May 1, 2026 12:55
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the SecureMint datafeeds aggregator implementation (and its tests) as part of de-scoping/removing the borsh-encoder-related SecureMint path referenced by the linked Chainlink PR.

Changes:

  • Delete SecureMintAggregator implementation and related packing/helpers.
  • Delete the corresponding unit tests for SecureMint aggregation and packing.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator.go Removes the SecureMint OCR3 datafeeds aggregator implementation and associated helpers/constants.
pkg/capabilities/consensus/ocr3/datafeeds/securemint_aggregator_test.go Removes the unit tests that validated SecureMint aggregation/config parsing/packing behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Unheilbar Unheilbar requested a review from jmank88 May 1, 2026 13:20
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm concerned about making breaking changes here. Even if core is the only user and updates quickly, it creates a point in time that we cannot easily move past for things like backports etc. and often breaks integration-tests in the chain repos. Could we leave it deprecated for a while? Or at least avoid break compilation?

@Unheilbar Unheilbar closed this May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants