[Devourer] Tune Void Metamorphosis fury drain constants#11549
Open
taherbert wants to merge 2 commits into
Open
[Devourer] Tune Void Metamorphosis fury drain constants#11549taherbert wants to merge 2 commits into
taherbert wants to merge 2 commits into
Conversation
First second after entering meta drains 10/s (not 15), and reduced drain while casting Collapsing Star / channeling Void Ray is 0.127x (not 0.15x). Measured from WarcraftLogs per-tick drain across current raid logs. The 15 + 1.455*exp(0.075*s) curve itself matches the logs and is unchanged.
ae17238 to
4c70ae4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Measured the in-meta fury drain constants in
fury_state_t::fury_drain_per_secondagainst WCL. The drain logs each 2 fury as a resource-change event under spell 473671, so both the instantaneous rate (2 divided by the time between ticks) and the full cumulative drain-event schedule are directly observable. Pulled ~100 current Devourer raid logs, 210 metas (Soul Glutton excluded).Three values were off:
drain_stacks < 1floor).15 + 1.455 * exp(0.075 * s). With only the two changes above, replaying SimC's drain scheduler through each logged meta (against that meta's actual Collapsing Star / Void Ray windows) tracks in-game cumulative drain counts mid-meta but falls ~9 drain events (~18 fury) behind by meta end, so sim metas would run ~0.3s long. Refit against the cumulative schedules:15 + 1.40 * exp(0.0775 * s)matches in-game cumulative drain events within +-2 at every checkpoint including meta end.For reference, the old constants (15/s first second, 0.15x reduced, 1.455/0.075 curve) do not match the in-game timeline either: they run 4-9 drain events ahead through mid-meta and only land near the correct end time because the too-shallow tail cancels the too-hot early drain.
Structure checks from the same logs: the acceleration steps once per second exactly like
drain_stacks(the within-second rate pattern is flat, not continuous-time), the quantum is exactly -2 per event, and Soul Glutton's 1.333x multiplier matches. Coverage past ~52s in meta is thin (few logged metas survive that long), so the tail beyond that is the fit's extrapolation.