-
Notifications
You must be signed in to change notification settings - Fork 3.7k
feat(tables): add select & multi-select column types #5873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TheodoreSpeaks
wants to merge
13
commits into
staging
Choose a base branch
from
feat/table-enum-type
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,107
−65
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
55bf638
feat(tables): add select/multiselect column types (backend)
TheodoreSpeaks d270a0f
feat(tables): select/multiselect column UI
TheodoreSpeaks 1fdfa3c
fix(tables): auto-fit select columns on option labels, not ids
TheodoreSpeaks b5ad728
feat(tables): default select options to grey, drop color picker for now
TheodoreSpeaks f7c6dd8
fix(tables): guard select type conversion, escape, and required clear
TheodoreSpeaks fce848c
fix(tables): block emptying required multiselect, skip no-op cell writes
TheodoreSpeaks 4db5e88
fix(tables): expanded multiselect string value + same-type options drop
TheodoreSpeaks a0f898a
improvement(tables): inline select edit + idiomatic options editor
TheodoreSpeaks 0646664
improvement(tables): inline select cell uses bare DropdownMenu
TheodoreSpeaks 2fbdc9c
improvement(tables): unify select into one type with a multiple flag
TheodoreSpeaks d55f94b
improvement(tables): revert select cell to chip-only view
TheodoreSpeaks 60b15cc
fix(tables): block multiple→single select switch when cells have >1 o…
TheodoreSpeaks d06c399
improvement(tables): rename select "Allow multiple" toggle to "Multis…
TheodoreSpeaks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/select-field/index.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export { SelectOptionsEditor } from './select-options-editor' | ||
| export { resolveSelectOptions, SelectPill, toSelectedIds } from './select-pill' | ||
| export { SelectValueEditor } from './select-value-editor' |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unique stuck on select convert
Low Severity
Converting a unique column to select hides the Unique control and suppresses
uniqueChanged, and the save payload never clearsunique. A previously unique column therefore keeps its unique constraint after becoming select, with no way to turn it off while the type remains select.Reviewed by Cursor Bugbot for commit d06c399. Configure here.