feat(tables): add select & multi-select column types by TheodoreSpeaks · Pull Request #5873 · simstudioai/sim

TheodoreSpeaks · 2026-07-23T00:42:29Z

Summary

Add select (single) and multiselect enum column types to Tables — a column declares a fixed set of options and every cell is constrained to them, rendered as pills
Cells store stable option ids (a string for select, string[] for multiselect) so renaming an option never rewrites row data; no DB migration (option set rides in the existing schema JSONB)
Server enforces membership and tolerantly maps an option name → its id for tool/import writes; empty/invalid optional cells coerce to null
Options are managed in the column-config sidebar; every select cell offers a "None" entry and empty cells read as "None"
Options render as neutral grey pills for now — the color field + full palette stay in the model/contract so a picker can be re-added later with no migration
Wired into all three edit surfaces (inline cell, expanded popover, row modal); ChipDropdown gains defaultOpen/onOpenChange for inline editing

Known limitations

Mothership can't create these columns yet — the copilot tool catalog doesn't expose options (follow-up)

Type of Change

New feature

Testing

Tested manually. bun run lint clean, check:api-validation:strict passed, check:react-query passed; 335 table + 14 emcn unit tests green (incl. new validation.test.ts covering membership, name→id coercion, and option-set validation)

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Adds two enum-style column types where the column declares a fixed set of options (stable id + name + palette color) and every cell is constrained to them. - COLUMN_TYPES gains `select` / `multiselect`; SELECT_COLORS is a fixed, theme-aware palette mapping 1:1 to Badge color variants (no raw hex) - ColumnDefinition.options carries the option set. Cells store option *ids* (a string for select, string[] for multiselect) so renaming or recoloring an option never rewrites row data - Row validation enforces membership; coercion tolerantly maps an option *name* to its id for tool/import writes and drops unmatched entries - validateColumnDefinition enforces non-empty, unique-id, unique-name and valid-color option sets, and rejects options on non-select columns - Contract gains selectOptionSchema plus a cross-field refine requiring options exactly on select types; routes thread options through type changes and a new options-only updateColumnOptions path No migration: column config already lives in the user_table_definitions schema JSONB blob. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e4MvFV1szLhNLap1CCNUd

Surfaces the new enum column types in the tables grid. - New `select-field/` module: SelectPill (colored option via the shared Badge palette), SelectValueEditor (one ChipDropdown-backed picker reused by every edit surface), SelectOptionsEditor (add/rename/recolor/remove) - Option colors are picked from inline squircle swatches — no labels, no nested dropdown. Each swatch's fill is a Badge in that variant, so the palette stays single-sourced and theme-aware - Cells render option pills; an empty select cell shows a muted "None" so it reads as a dropdown. The single-select menu always offers "None" to clear - Wired into all three edit surfaces (inline cell, expanded popover, row modal) plus the type picker and column-type icons - ChipDropdown gains `defaultOpen`/`onOpenChange` so the inline cell editor can open on mount and commit when the menu closes; open state is now controlled in both single and multi modes Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e4MvFV1szLhNLap1CCNUd

Column auto-resize measured `String(val)` for every non-json/date column, which for a select cell is the opaque option id (and for multiselect the comma-joined id array). Selecting auto-fit on a select column therefore sized it to ids the user never sees. Measure the resolved option names instead, matching what the pills actually render. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e4MvFV1szLhNLap1CCNUd

Removes the per-option swatch picker and defaults every option to the neutral gray pill. The `color` field stays in the data model and the SELECT_COLORS palette/contract are untouched, so a picker can be re-added later as a pure UI change with no migration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014e4MvFV1szLhNLap1CCNUd

vercel · 2026-07-23T00:42:35Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Jul 23, 2026 9:02pm

cursor · 2026-07-23T00:42:40Z

PR Summary

Medium Risk
Touches shared table schema validation, column mutation paths, and row write coercion across internal and v1 APIs; behavior is covered by new validation tests but option-set edge cases (stale ids, multi→single) affect existing row data.

Overview
Introduces a select column type (optional multiple) where the schema holds a fixed option set and cells store stable option ids (string or string[]), with no DB migration.

API & schema: Zod contracts and normalizeColumn now carry options / multiple. Column PATCH routes distinguish a real type change from options-only updates so unchanged type + new options no longer get dropped by updateColumnType. New updateColumnOptions handles option edits and blocks multi→single when rows still have multiple selections. Row/column validation, coercion (name→id for imports), and type-conversion compatibility checks are extended for select.

UI: Select appears in the new-column and edit sidebars (SelectOptionsEditor, allow-multiple toggle; unique hidden for select). Grid cells render pills, inline dropdown editing, row-modal picker, and structural equality for undo/no-op saves; column auto-fit uses option labels.

^{Reviewed by Cursor Bugbot for commit 60b15cc. Bugbot is set up for automated code reviews on this repo. Configure here.}

greptile-apps · 2026-07-23T00:44:35Z

Greptile Summary

This PR adds select and multiselect columns to Tables. The main changes are:

Stable option IDs with schema and row validation.
Option management in the column configuration sidebar.
Pill rendering and editing across table views.
Compatibility checks for column type conversions.
Required-value guards for select editors.

Confidence Score: 5/5

This looks safe to merge.

The conversion fix checks stored values against the target option set.
Required select and multiselect editors prevent invalid clear actions.
No blocking issue remains within the follow-up scope.

Important Files Changed

Filename	Overview
apps/sim/lib/table/columns/service.ts	Adds option-aware column creation, type conversion checks, and option updates.
apps/sim/lib/table/validation.ts	Adds option-set validation, membership checks, and name-to-ID coercion.
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/select-field/select-value-editor.tsx	Adds shared single-select and multiselect editing with required-value guards.
packages/emcn/src/components/chip-dropdown/chip-dropdown.tsx	Adds initial open state and open-state notifications for inline editing.

_{Reviews (5): Last reviewed commit: "improvement(tables): inline select edit ..." | Re-trigger Greptile}

Addresses review findings on the select/multiselect column types: - Column type conversion now checks each existing value against the target option set (resolve by id or name); a `select`/`multiselect` change is blocked when values don't fit, instead of accepting shapes that later coercion would strand or silently drop - Inline select editor discards its draft on Escape (matching the text/date editors) rather than committing on menu close - A required single-select no longer offers "None" — clearing to null could never be committed Exports resolveSelectOptionId from validation for the conversion gate.

TheodoreSpeaks · 2026-07-23T02:17:24Z

@greptile

TheodoreSpeaks · 2026-07-23T02:17:25Z

@cursor review

Round 2 review fixes: - A required multiselect can no longer be emptied — the toggle that would remove the last option is ignored, since an empty selection can't be committed (server rejects it). Mirrors the required single-select "None" guard. - Inline cell save now compares old vs new value structurally, so a no-op edit (e.g. opening a multiselect and closing it unchanged, producing a new array reference) no longer writes a row update or pushes an undo entry. Uses JSON compare for arrays/objects, matching the existing optionsEqual convention; primitives keep the === fast path.

TheodoreSpeaks · 2026-07-23T02:26:39Z

@greptile

TheodoreSpeaks · 2026-07-23T02:26:40Z

@cursor review

Round 3 review fixes: - Expanded-cell popover normalizes a multiselect's initial value with toSelectedIds, so a single option-id string (the normal shape right after a select->multiselect conversion, before the row is rewritten) is no longer collapsed to an empty array and cleared on save. - Column PATCH now only routes to updateColumnType on a real type change. updateColumnType early-returns on an unchanged type, so a payload repeating the current type together with new options previously applied neither; an unchanged type with options now routes to the options-only update. Fixed in both the internal and v1 column routes.

TheodoreSpeaks · 2026-07-23T02:36:16Z

@greptile

TheodoreSpeaks · 2026-07-23T02:36:17Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 4db5e88. Configure here.}

- Double-clicking a select/multiselect cell now opens the inline option dropdown (like date/number) instead of the fixed-height text popover, which rendered just a small dropdown floating in a large empty container. Removes the now-unreachable ExpandedSelectEditor from the expanded-cell popover. - Options editor's add/remove controls match the sibling Filter UI: a ghost, muted "Add option" button with a small plus, and an X remove icon.

TheodoreSpeaks · 2026-07-23T08:08:31Z

@greptile

TheodoreSpeaks · 2026-07-23T08:08:32Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a0f898a. Configure here.}

The inline select editor used a ChipDropdown pill, which reads as a foreign form control inside a grid cell. It now renders the canonical DropdownMenu anchored to the cell — an invisible full-cell trigger (no pill, no label text), options as their colored pills with a check on the selected ones, and "None" as a proper menu item. The cell keeps showing its pills while the menu is open instead of going blank. SelectValueEditor (the ChipDropdown pill) is now used only by the row modal, where a pill form control is idiomatic. This lets the defaultOpen/onOpenChange additions to the shared ChipDropdown be reverted — it's back to its original behavior with no consumers depending on the change.

cursor · 2026-07-23T18:10:39Z

+  targetOptions: SelectOption[] = []
 ): boolean {
-  if (value === null || value === undefined) return true
+  if (value === null || value === undefined || value === '') return true


Empty strings bypass type checks

Medium Severity

isValueCompatibleWithType now treats '' as compatible for every target type, not only select. A string column with empty-string cells can convert to number/date/boolean, leaving invalid values that later block or null out on row writes.

^{Reviewed by Cursor Bugbot for commit 0646664. Configure here.}

cursor · 2026-07-23T18:10:39Z

+ * Updates the option set of a `select`/`multiselect` column without changing its
+ * type. Existing cell values are left untouched — ids that no longer match an
+ * option render as a neutral fallback pill until reassigned.
+ */


Deleted options break row writes

High Severity

updateColumnOptions keeps orphaned cell ids after an option is removed, but every row write runs coerceRowToSchema on the full merged row. Optional orphans are nulled, multiselect orphans are stripped, and required orphans fail validation—so editing unrelated cells can erase select data or block the row.

Additional Locations (2)

apps/sim/lib/table/validation.ts#L361-L373

apps/sim/lib/table/validation.ts#L267-L284

^{Reviewed by Cursor Bugbot for commit 0646664. Configure here.}

cursor · 2026-07-23T18:10:40Z

+        const id = resolveSelectOptionId(entry, column.options ?? [])
+        if (id !== null && !ids.includes(id)) ids.push(id)
+      }
+      return { ok: true, value: ids }


Invalid multiselect coerces to empty

Medium Severity

Multiselect coercion always returns { ok: true, value: ids }, so a fully unmatched optional value becomes [] instead of null. That conflicts with select behavior and the stated rule that invalid optional cells coerce to null, and it persists empty arrays on import/tool writes.

^{Reviewed by Cursor Bugbot for commit 0646664. Configure here.}

- Collapse `select` + `multiselect` into a single `select` column type with a `multiple` boolean. A cell holds one option id when single, an array when multiple. Validation/coercion, the contract, routes, and all cell/editor code now branch on `column.multiple` instead of a separate type. - The column-config sidebar exposes an "Allow multiple" toggle (create and edit) and no longer offers "Unique" on select columns. - Give the closed select cell a dropdown affordance: it renders emcn's `comboboxVariants` chrome (border + chevron, compacted to the row height), with the pills inside and the chevron flipping while the menu is open. - Single↔multiple toggles reconcile lazily on the next row write (single tolerates an array by taking its first resolved option).

Drop the combobox chrome (border + chevron) from the select cell — the plain option pills read better. Reverts the comboboxVariants barrel export too, since nothing else uses it.

cursor · 2026-07-23T20:51:34Z

+        fullWidth={fullWidth}
+        matchTriggerWidth={false}
+      />
+    )


Empty multiselect shows All

Medium Severity

SelectValueEditor sets showAllOption={false} and placeholder='Select options' for multiselect, but ChipDropdown in multiple mode ignores placeholder and renders allLabel (defaulting to All) when the selection is empty. Empty optional multiselect cells in the row modal therefore read as if every option were selected.

^{Reviewed by Cursor Bugbot for commit d55f94b. Configure here.}

…ption Switching a select column from multiple to single would silently keep only the first option of any multi-valued cell. updateColumnOptions now scans the rows on that transition and errors ("N row(s) have multiple options selected") instead of dropping data, mirroring the type-change compatibility guard.

cursor

Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.

There are 6 total unresolved issues (including 4 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 60b15cc. Configure here.}

cursor · 2026-07-23T21:05:06Z

+      // Single or multi, every part of the value must resolve to an option.
+      const parts = Array.isArray(value) ? value : [value]
+      return parts.every((v) => resolveSelectOptionId(v as JsonValue, targetOptions) !== null)
+    }


Single-select conversion allows multi-values

Medium Severity

isValueCompatibleWithType for select only checks that every array element resolves to an option. It never consults whether the target is single-select, so a multi-element array is treated as compatible. updateColumnOptions already blocks multi→single for this reason and even comments that it mirrors a type-change guard, but that guard is missing here—so conversion can leave arrays that the next coerce silently reduces to the first id.

^{Reviewed by Cursor Bugbot for commit 60b15cc. Configure here.}

cursor · 2026-07-23T21:05:06Z

  switch (targetType) {
    case 'string':
      return true
+    case 'select': {


Multiselect-to-text drops array data

Medium Severity

Compatibility for target type string returns true for any value, including multiselect string[] cells. Changing a multiselect column to text therefore succeeds while leaving arrays in row data; the next coerce cannot turn those arrays into strings and nulls optional cells (or fails required ones), so selections are lost without the conversion error used for number/date/boolean.

^{Reviewed by Cursor Bugbot for commit 60b15cc. Configure here.}

TheodoreSpeaks and others added 4 commits July 22, 2026 14:31

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/lib/table/columns/service.ts Outdated

Comment thread .../app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/inline-editors.tsx Outdated

greptile-apps Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/lib/table/columns/service.ts Outdated

Comment thread ...app/workspace/[workspaceId]/tables/[tableId]/components/select-field/select-value-editor.tsx Outdated

vercel Bot deployed to Preview July 23, 2026 00:47 View deployment

vercel Bot temporarily deployed to Preview July 23, 2026 02:16 Inactive

greptile-apps Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread ...app/workspace/[workspaceId]/tables/[tableId]/components/select-field/select-value-editor.tsx Outdated

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/app/api/table/[tableId]/columns/route.ts Outdated

vercel Bot temporarily deployed to Preview July 23, 2026 02:26 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread ...rkspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/expanded-cell-popover.tsx Outdated

Comment thread apps/sim/app/api/table/[tableId]/columns/route.ts Outdated

vercel Bot temporarily deployed to Preview July 23, 2026 02:35 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

vercel Bot temporarily deployed to Preview July 23, 2026 08:08 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

vercel Bot deployed to Preview July 23, 2026 18:11 View deployment

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread apps/sim/lib/table/validation.ts

Comment thread apps/sim/lib/table/columns/service.ts

Comment thread apps/sim/lib/table/columns/service.ts

vercel Bot deployed to Preview July 23, 2026 19:39 View deployment

improvement(tables): revert select cell to chip-only view

d55f94b

Drop the combobox chrome (border + chevron) from the select cell — the plain option pills read better. Reverts the comboboxVariants barrel export too, since nothing else uses it.

cursor Bot reviewed Jul 23, 2026

View reviewed changes

vercel Bot deployed to Preview July 23, 2026 20:53 View deployment

vercel Bot temporarily deployed to Preview July 23, 2026 21:02 Inactive

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Uh oh!

Conversation

TheodoreSpeaks commented Jul 23, 2026

Summary

Known limitations

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

TheodoreSpeaks commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Empty strings bypass type checks

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Deleted options break row writes

Uh oh!

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Invalid multiselect coerces to empty

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Empty multiselect shows All

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

cursor Bot Jul 23, 2026

Choose a reason for hiding this comment

Single-select conversion allows multi-values

vercel Bot commented Jul 23, 2026 •

edited

Loading

cursor Bot commented Jul 23, 2026 •

edited

Loading

greptile-apps Bot commented Jul 23, 2026 •

edited

Loading