docs: update XML service and route definition examples to PHP format - #2401
Open
Umut Dogan (umutdogan4291) wants to merge 5 commits into
Open
docs: update XML service and route definition examples to PHP format#2401Umut Dogan (umutdogan4291) wants to merge 5 commits into
Umut Dogan (umutdogan4291) wants to merge 5 commits into
Conversation
Developer Docs healthcheckStatus: Completed with |
Umut Dogan (umutdogan4291)
marked this pull request as draft
July 27, 2026 12:37
Umut Dogan (umutdogan4291)
marked this pull request as ready for review
July 28, 2026 06:56
Michael Telgmann (mitelg)
approved these changes
Jul 28, 2026
| After adding the definition to the line item, we have to calculate the current price of the discount. Therefore we can use the `PercentagePriceCalculator` of the core. The last step is to add the discount to the new cart which is provided as `Cart $toCalculate`. | ||
|
|
||
| That's it for the main code of our custom `CartProcessor`. Now we only have to register it in our `services.php` using the tag `shopware.cart.processor` and priority `4500`, which is used to get access to the calculation after the [product processor](https://github.com/shopware/shopware/blob/v6.3.4.1/src/Core/Checkout/DependencyInjection/cart.xml#L223-L231) handled the products. | ||
| That's it for the main code of our custom `CartProcessor`. Now we only have to register it in our `services.php` using the tag `shopware.cart.processor` and priority `4500`, which is used to get access to the calculation after the [product processor](https://github.com/shopware/shopware/blob/28ee9f4f98f2a626c7a53bf2c341443c54756d5c/src/Core/Checkout/DependencyInjection/cart.php#L505-L516) handled the products. |
There was a problem hiding this comment.
should we add a concrete version instead? 🤔
Contributor
Author
There was a problem hiding this comment.
I hesitated to add because it's not in any version yet 🤔 merged in 18472
Can we assume it will be released and use it's milestone
https://github.com/shopware/shopware/blob/v6.7.14.0/src/Core/Checkout/DependencyInjection/cart.php#L505-L516
There was a problem hiding this comment.
at least your commit is not on the 6.7.13.x branch 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XML DI configuration is deprecated since Symfony 7.4 and core/extension configs were migrated to PHP.
Updates all remaining service and route definition examples (MCP server, caching, Migration Assistant, Subscriptions) to the ContainerConfigurator/RoutingConfigurator style.
ADRs and non-Symfony XML configs are intentionally unchanged.
Related links
shopware/shopware#13072
Checklist
PageRefreferences where relevant..gitbook.yamlif pages were moved, renamed, or deleted..wordlist.txt(and sorted it) if spellcheck flags new legitimate terms.Notes