Pin cpflow workflows to Ruby setup fallback#742
Conversation
🚀 Quick Review App CommandsWelcome! Here are the commands you can use in this PR:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughSeven workflow files that delegate to upstream ChangesReusable workflow reference updates
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR re-pins all seven cpflow GitHub Actions reusable workflow wrappers from upstream commit
Confidence Score: 5/5Safe to merge — the change is a consistent SHA bump across all seven workflow files with no logic modifications. Every workflow file is updated uniformly: the uses: SHA and control_plane_flow_ref input both point to the new commit where the input exists, and the two workflows that don't use control_plane_flow_ref are handled correctly. The new commit is still SHA-pinned, not a mutable ref. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GitHub Event Trigger] --> B{Workflow Type}
B --> C[cpflow-deploy-staging]
B --> D[cpflow-deploy-review-app]
B --> E[cpflow-delete-review-app]
B --> F[cpflow-cleanup-stale-review-apps]
B --> G[cpflow-promote-staging-to-production]
B --> H[cpflow-help-command]
B --> I[cpflow-review-app-help]
C --> J["shakacode/control-plane-flow@6f44c840\n(was 8e9c0c5)"]
D --> J
E --> J
F --> J
G --> J
H --> J
I --> J
J --> K[cpflow-setup-environment\nRuby fallback fix included]
Reviews (1): Last reviewed commit: "Pin cpflow workflows to Ruby setup fallb..." | Re-trigger Greptile |
Code Review: Pin cpflow workflows to Ruby setup fallbackOverviewThis PR updates 7 GitHub Actions workflow wrappers to repin from upstream commit What's done well
Pre-existing inconsistency worth notingTwo workflows (
Could you confirm whether these two upstream workflows accept Risk AssessmentLow risk — mechanically correct, no logic changes, all 7 files updated consistently. Risk is bounded to potential regressions in commit Suggested pre-merge check: Confirm |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| contains(fromJson('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) || | ||
| github.event_name == 'workflow_dispatch' | ||
| uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c | ||
| uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0 |
There was a problem hiding this comment.
This workflow (and cpflow-review-app-help.yml) omits the with: control_plane_flow_ref: block that the other 5 cpflow wrappers all pass. If the upstream cpflow-help-command.yml reusable workflow accepts that input, the missing block means it won't be fully pinned — it could resolve control_plane_flow_ref to a default (e.g. a branch tip) instead of the commit SHA in the uses: ref.
If the upstream workflow does accept it, the fix would be:
| uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0 | |
| uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0 | |
| with: | |
| control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0 |
If it doesn't declare that input at all, this is fine as-is — just worth a quick confirmation.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
❌ Failed to Delete Review AppFailed to delete review app for PR #742 |
1 participant
Summary
Verification
Note
Low Risk
Low risk: this only changes which upstream reusable GitHub Actions workflows are referenced, but it can affect deploy/review-app automation behavior if the new pinned ref has regressions.
Overview
Repins all
cpflow-*GitHub Actions workflow wrappers to a newer pinnedshakacode/control-plane-flowcommit (6f44c840…), updating both theuses:refs and matchingcontrol_plane_flow_refinputs.This affects the reusable workflows for staging deploy, review app deploy/delete/help, stale review app cleanup, and staging promotion, and is intended to pick up the upstream environment-setup (Ruby fallback) fix.
Reviewed by Cursor Bugbot for commit f3544e8. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit