Skip to content

Pin cpflow workflows to Ruby setup fallback #742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justin808 merged 1 commit into from
May 22, 2026
Merged

Pin cpflow workflows to Ruby setup fallback #742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cpflow-cleanup-stale-review-apps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ permissions:

jobs:
cleanup:
uses: shakacode/control-plane-flow/.github/workflows/cpflow-cleanup-stale-review-apps.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-cleanup-stale-review-apps.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 8e9c0c5e9991ac8651ae2721830bf5231f34de5c
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
secrets: inherit
4 changes: 2 additions & 2 deletions .github/workflows/cpflow-delete-review-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
contains(fromJson('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) ||
(github.event_name == 'pull_request_target' && github.event.action == 'closed') ||
github.event_name == 'workflow_dispatch'
uses: shakacode/control-plane-flow/.github/workflows/cpflow-delete-review-app.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-delete-review-app.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 8e9c0c5e9991ac8651ae2721830bf5231f34de5c
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
secrets: inherit
4 changes: 2 additions & 2 deletions .github/workflows/cpflow-deploy-review-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ jobs:
github.event.issue.pull_request &&
contains(fromJson('["+review-app-deploy","+review-app-deploy\n","+review-app-deploy\r\n"]'), github.event.comment.body) &&
contains(fromJson('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association))
uses: shakacode/control-plane-flow/.github/workflows/cpflow-deploy-review-app.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-deploy-review-app.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 8e9c0c5e9991ac8651ae2721830bf5231f34de5c
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
secrets: inherit
4 changes: 2 additions & 2 deletions .github/workflows/cpflow-deploy-staging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ permissions:

jobs:
deploy-staging:
uses: shakacode/control-plane-flow/.github/workflows/cpflow-deploy-staging.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-deploy-staging.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 8e9c0c5e9991ac8651ae2721830bf5231f34de5c
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
staging_app_branch_default: ""
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/cpflow-help-command.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@ jobs:
contains(fromJson('["+review-app-help","+review-app-help\n","+review-app-help\r\n"]'), github.event.comment.body) &&
contains(fromJson('["OWNER","MEMBER","COLLABORATOR"]'), github.event.comment.author_association)) ||
github.event_name == 'workflow_dispatch'
uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
Copy link
Copy Markdown

@claude claude Bot May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow (and cpflow-review-app-help.yml) omits the with: control_plane_flow_ref: block that the other 5 cpflow wrappers all pass. If the upstream cpflow-help-command.yml reusable workflow accepts that input, the missing block means it won't be fully pinned — it could resolve control_plane_flow_ref to a default (e.g. a branch tip) instead of the commit SHA in the uses: ref.

If the upstream workflow does accept it, the fix would be:

Suggested change
uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
uses: shakacode/control-plane-flow/.github/workflows/cpflow-help-command.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0

If it doesn't declare that input at all, this is fine as-is — just worth a quick confirmation.

4 changes: 2 additions & 2 deletions .github/workflows/cpflow-promote-staging-to-production.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:
jobs:
promote-to-production:
if: github.event.inputs.confirm_promotion == 'promote'
uses: shakacode/control-plane-flow/.github/workflows/cpflow-promote-staging-to-production.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-promote-staging-to-production.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
with:
control_plane_flow_ref: 8e9c0c5e9991ac8651ae2721830bf5231f34de5c
control_plane_flow_ref: 6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
secrets: inherit
2 changes: 1 addition & 1 deletion .github/workflows/cpflow-review-app-help.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ permissions:
jobs:
show-help:
if: vars.REVIEW_APP_PREFIX != ''
uses: shakacode/control-plane-flow/.github/workflows/cpflow-review-app-help.yml@8e9c0c5e9991ac8651ae2721830bf5231f34de5c
uses: shakacode/control-plane-flow/.github/workflows/cpflow-review-app-help.yml@6f44c84049d4fa09aaa8c0a72cc436cd52e66fb0
Loading