a few parsing and infrastructure upgrades - #7734
Draft
Goober5000 wants to merge 2 commits into
Draft
Conversation
Goober5000
added
fix
Goober5000
force-pushed
the
fix/ship_registry_rename
branch
2 times, most recently
from
August 23, 2026 19:16
bf4457d to
195cce8
Compare
Following PR scp-fs2open#7429, ships belonging to wings were hashed the same way as every other ship, instead of the original hackish format where the hash was juggled around the number. This was a mostly transparent upgrade, and ship names were automatically converted from the legacy format to the new format. However, missions that referenced ships *in subsequent waves* broke; the converter only handled ships in the first wave. This PR adds compatibility checks to `eval_ship` and `ship_registry_get` to accommodate legacy names.
- A parse flag to indicate when the mission is being parsed, and a new `ship_class_index()` accessor in the ship registry, both currently unused - Make the ship registry more robust, especially in FRED: properly update it when ships are renamed or deleted
Goober5000
force-pushed
the
fix/ship_registry_rename
branch
from
August 23, 2026 20:08
195cce8 to
7b99921
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ship_class_index()accessor in the ship registry, both currently unusedIn draft as it depends on #7732