clean up check_sexp_syntax and improve caching - #7735
Draft
Goober5000 wants to merge 2 commits into
Draft
Conversation
Goober5000
added
cleanup
Goober5000
force-pushed
the
cleanup/sexp_syntax_checking
branch
4 times, most recently
from
August 24, 2026 01:41
9e53586 to
a81ba38
Compare
- A parse flag to indicate when the mission is being parsed, and a new `ship_class_index()` accessor in the ship registry, both currently unused - Make the ship registry more robust, especially in FRED: properly update it when ships are renamed or deleted
- Clean up `check_sexp_syntax` to use `eval_ship` (and incidentally `eval_wing` and `eval_prop`) rather than the old lookups. - Disable SEXP node caching while FRED is running. Also use smart pointers and fix a cache memory leak.
Goober5000
force-pushed
the
cleanup/sexp_syntax_checking
branch
from
August 24, 2026 02:25
a81ba38 to
f759019
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_sexp_syntaxto useeval_ship(and incidentallyeval_wingandeval_prop) rather than the old lookups.In draft as it depends on #7734