wing name format compatibility - #7732
Draft
Goober5000 wants to merge 1 commit into
Draft
Conversation
Goober5000
added
fix
Goober5000
marked this pull request as draft
August 22, 2026 19:47
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
from
August 23, 2026 03:13
14e002c to
7de169d
Compare
Goober5000
marked this pull request as ready for review
August 23, 2026 03:13
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
4 times, most recently
from
August 23, 2026 17:45
3384eb0 to
2934775
Compare
Goober5000
changed the title
wookieejedi
approved these changes
Aug 23, 2026
Goober5000
marked this pull request as draft
August 23, 2026 18:46
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
from
August 23, 2026 18:53
2934775 to
3434495
Compare
Goober5000
marked this pull request as ready for review
August 23, 2026 18:55
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
from
August 23, 2026 18:57
3434495 to
c7080b1
Compare
Goober5000
marked this pull request as draft
August 23, 2026 19:30
Following PR scp-fs2open#7429, ships belonging to wings were hashed the same way as every other ship, instead of the original hackish format where the hash was juggled around the number. This was a mostly transparent upgrade, and ship names were automatically converted from the legacy format to the new format. However, missions that referenced ships *in subsequent waves* broke; the converter only handled ships in the first wave. This PR adds compatibility checks to `eval_ship` and `ship_registry_get` to accommodate legacy names.
Goober5000
force-pushed
the
fix/wing_hash_compatibility
branch
from
August 23, 2026 20:08
c7080b1 to
ba6599c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following PR #7429, ships belonging to wings were hashed the same way as every other ship, instead of the original hackish format where the hash was juggled around the number. This was a mostly transparent upgrade, and ship names were automatically converted from the legacy format to the new format. However, missions that referenced ships in subsequent waves broke; the converter only handled ships in the first wave.
This PR adds compatibility checks to
eval_shipandship_registry_getto accommodate legacy names.