[pull] main from aidenybai:main - #156
Merged
Merged
Conversation
The paired perf bench checked out base `packages/react-grab/src` while leaving the PR's installed dependencies in place, so a dependency bump left base src importing an export the new version dropped. All 15 shards died at fixture startup and the aggregate gate failed a PR whose own code was fine — bippy 0.7.2 removing `getNearestHostFibers` did this to #626 and #621. The swap now takes the base manifests and lockfile too whenever the PR touches one, which both makes the baseline buildable and makes it the comparison a dependency bump actually wants. Manifests the PR adds are dropped first so the base lockfile passes its frozen check, and a base install that still fails falls back to skipping the baseline. The baseline run is also no longer fatal. It is a measurement, not a gate: the base ref has its own CI, and diff-perf-runs.mjs already reports a missing comparison instead of failing.
* chore: bump bippy to 0.7.2 Co-authored-by: aiden <aiden@million.dev> * fix: migrate removed bippy fiber traversal Co-authored-by: aiden <aiden@million.dev> * fix: align with bippy 0.7 fiber types Co-authored-by: aiden <aiden@million.dev> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )