Skip to content

chore: migrate tests to Rstest #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jul 10, 2026
+68 −15
Merged

chore: migrate tests to Rstest #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,15 @@
"dev": "rslib -w",
"lint": "rslint && prettier -c .",
"lint:write": "rslint --fix && prettier -w .",
"test": "playwright test",
"test": "rstest",
"bump": "pnpx bumpp"
},
"devDependencies": {
"@playwright/test": "^1.61.1",
"@rsbuild/core": "^2.1.5",
"@rslib/core": "^0.23.2",
"@rslint/core": "^0.6.5",
"@rstest/core": "^0.11.1",
"@rstest/playwright": "^0.11.1",
"@types/node": "^24.13.3",
"playwright": "^1.61.1",
"prettier": "^3.9.4",
Expand Down
70 changes: 58 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions pnpm-workspace.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ allowBuilds:
minimumReleaseAgeExclude:
- typescript
- '@typescript/*'
- '@rstest/*'
5 changes: 5 additions & 0 deletions rstest.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { defineConfig } from '@rstest/core';

export default defineConfig({
isolate: false,
});
Comment on lines +3 to +5

@chatgpt-codex-connector chatgpt-codex-connector Bot Jul 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the longer E2E test timeout

With this migration, these Rsbuild E2E tests now inherit Rstest's 5,000 ms default test timeout, whereas Playwright Test previously allowed 30,000 ms per test. In CI or on slower Windows runners, the rsbuild.build()/dev-server startup in test/basic/index.test.ts can legitimately take more than five seconds, causing the migrated suite to time out even though it passed under the old runner; set testTimeout here to preserve the previous budget.

Useful? React with 👍 / 👎.

2 changes: 1 addition & 1 deletion test/basic/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { dirname } from 'node:path';
import { fileURLToPath } from 'node:url';
import { expect, test } from '@playwright/test';
import { expect, test } from '@rstest/playwright';
import { createRsbuild } from '@rsbuild/core';
import { pluginExample } from '../../src';
import { getRandomPort } from '../helper';
Expand Down