Skip to content

chore: migrate tests to Rstest#64

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-migrate-to-rstest
Jul 10, 2026
Merged

chore: migrate tests to Rstest#64
chenjiahan merged 1 commit into
mainfrom
chenjiahan/chore-migrate-to-rstest

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

This PR migrates the test runner from @playwright/test to Rstest so the template uses the Rstack testing workflow while retaining Playwright browser automation. It adds @rstest/core and @rstest/playwright, configures module reuse, and updates the existing E2E tests without changing their coverage.

Related Links

@chenjiahan chenjiahan marked this pull request as ready for review July 10, 2026 07:02
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@chenjiahan, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 11 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 048fff56-62fb-4d0e-b392-0dc11bdca89a

📥 Commits

Reviewing files that changed from the base of the PR and between 8add1ab and 29aadd9.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • package.json
  • pnpm-workspace.yaml
  • rstest.config.ts
  • test/basic/index.test.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chenjiahan/chore-migrate-to-rstest

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chenjiahan chenjiahan merged commit 9c0cc83 into main Jul 10, 2026
7 checks passed
@chenjiahan chenjiahan deleted the chenjiahan/chore-migrate-to-rstest branch July 10, 2026 07:05

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 29aadd961e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rstest.config.ts
Comment on lines +3 to +5
export default defineConfig({
isolate: false,
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the longer E2E test timeout

With this migration, these Rsbuild E2E tests now inherit Rstest's 5,000 ms default test timeout, whereas Playwright Test previously allowed 30,000 ms per test. In CI or on slower Windows runners, the rsbuild.build()/dev-server startup in test/basic/index.test.ts can legitimately take more than five seconds, causing the migrated suite to time out even though it passed under the old runner; set testTimeout here to preserve the previous budget.

Useful? React with 👍 / 👎.

This was referenced Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant