chore: migrate tests to Rstest#64
Conversation
|
Warning Review limit reached
Next review available in: 11 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 29aadd961e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| export default defineConfig({ | ||
| isolate: false, | ||
| }); |
There was a problem hiding this comment.
Preserve the longer E2E test timeout
With this migration, these Rsbuild E2E tests now inherit Rstest's 5,000 ms default test timeout, whereas Playwright Test previously allowed 30,000 ms per test. In CI or on slower Windows runners, the rsbuild.build()/dev-server startup in test/basic/index.test.ts can legitimately take more than five seconds, causing the migrated suite to time out even though it passed under the old runner; set testTimeout here to preserve the previous budget.
Useful? React with 👍 / 👎.
This PR migrates the test runner from
@playwright/testto Rstest so the template uses the Rstack testing workflow while retaining Playwright browser automation. It adds@rstest/coreand@rstest/playwright, configures module reuse, and updates the existing E2E tests without changing their coverage.Related Links