chore(tests): use a neutral example host in the base_url test - #5
Merged
Conversation
The base_url override test used a real customer's branded gateway hostname. A public SDK test should not name an actual deployment. Replaced with `gateway.example.com`. The assertion is unchanged in substance -- it checks that a caller-supplied base_url reaches the underlying client verbatim, and any host proves that equally well.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
base_urloverride test used a real customer's branded gateway hostname. A public SDK test should not name an actual deployment.Replaced with
gateway.example.com. The assertion is unchanged in substance — it checks that a caller-suppliedbase_urlreaches the underlying client verbatim, and any host proves that equally well.Found while sweeping all four public repos for customer and founder names, after the same class of leak turned up in the Community Edition test fixtures.
routeplane-devtoolsandrouteplane-api-docsscanned clean (positive-controlled, so a silently-broken scan would have shown itself).