[roottest] use less ROOTSYS

[ferdymercury]

No description provided.

[github-actions]

Test Results

    22 files      22 suites   3d 7h 4m 18s ⏱️
 3 850 tests  3 848 ✅  1 💤 1 ❌
76 007 runs  75 988 ✅ 18 💤 1 ❌

For more details on these failures, see this check.

Results for commit eaf1e1b.

♻️ This comment has been updated with latest results.

[dpiparo]

This is the right direction to go. Maybe @guitargeek wants to chime in with his packaging expertise, given that in these cases, the coverage guaranteed by the CI is not always enough.

[guitargeek]

Thanks for the PR! Avoiding to use ROOTSYS as a CMake variable is definitely good to avoid confusion with the environment variable of the same name which I try to get rid of 👍

Can you change the PR though to not introduce new cached variables? You do it here:

set(ROOT_LIBRARY_DIR ${CMAKE_BINARY_DIR}/lib CACHE INTERNAL "")
set(ROOT_INCLUDE_DIRS ${CMAKE_BINARY_DIR}/include CACHE INTERNAL "")

I think the target-based configuration that you suggest yourself would be a way to achieve this.

[guitargeek]

Thank you very much! Also for considering the review comments.

[guitargeek]

Ah damn I'm sorry, sometimes the muscle memory skips the squash on merge 🙁 Occasionally that happens, pardon