Skip to content

fix(android): start the configured state machine when deferring autoplay #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Nodonisko wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

fix(android): start the configured state machine when deferring autoplay #374

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion android/src/legacy/java/com/rive/RiveReactNativeView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,18 @@ class RiveReactNativeView(context: ThemedReactContext) : FrameLayout(context) {
// Create the state machine without advancing Entry transitions.
// The first Choreographer frame will advance it with the user's
// VM instance already bound via applyDataBinding() below.
riveAnimationView?.play(settleInitialState = false)
//
// Start the configured state machine explicitly: on a cold start the
// no-arg play() also starts the artboard's first raw timeline
// animation (same class of bug as #332), which plays on top of the
// data-bound state machine and shows the wrong state.
val smName = config.stateMachineName
?: riveAnimationView?.controller?.activeArtboard?.stateMachineNames?.firstOrNull()
if (smName != null) {
riveAnimationView?.play(smName, isStateMachine = true, settleInitialState = false)
} else {
riveAnimationView?.play(settleInitialState = false)
}
}
_activeStateMachineName = getSafeStateMachineName()
configuredStateMachineName = config.stateMachineName
Expand Down