fix(android): start the configured state machine when deferring autoplay - #374
Open
Nodonisko wants to merge 1 commit into
Open
fix(android): start the configured state machine when deferring autoplay#374Nodonisko wants to merge 1 commit into
Nodonisko wants to merge 1 commit into
Conversation
The deferAutoPlay branch in configure() used the no-arg play(), which on a cold start also starts the artboard's first raw timeline animation. That timeline then draws over the data-bound state machine, showing the wrong state. Same bug class as rive-app#332, already fixed for the public play() in rive-app#343 - this applies the same explicit start to the internal call site. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
deferAutoPlaybranch inconfigure()calls the no-argplay(settleInitialState = false). On a cold start the controller's no-argplay()also starts the artboard's first raw timeline animation, which draws over the data-bound state machine and shows the wrong state — e.g. a file whose first timeline is a "fail" animation shows the failure art on every mount on Android, regardless of the bound VM values. iOS is unaffected.Same bug class as #332, which #343 fixed for the public
play()— this applies the same explicit state-machine start to the internal call site. Repro: any<RiveView dataBind={...} />(defaultautoPlay) on Android whose artboard's first linear animation visibly differs from the initial state-machine state.Co-Authored-By: Claude noreply@anthropic.com