Skip to content

ci_scripts: parse deprecated.txt comments dynamically #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justeph merged 1 commit into from
Aug 21, 2026
Merged

ci_scripts: parse deprecated.txt comments dynamically #300

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ci_scripts/check_versions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,8 +206,13 @@ def create_deprecation_pr(package: str, reason: str) -> Optional[str]:
deprecated_file = Path("ci_scripts/deprecated.txt")
lines = deprecated_file.read_text().splitlines()

comments = lines[:7]
deprecated_packages = lines[7:]
i = next(
i for i, line in enumerate(lines)
if line.strip() and not line.lstrip().startswith("#")
)

comments = lines[:i]
deprecated_packages = lines[i:]

if package not in deprecated_packages:
deprecated_packages.append(package)
Expand Down
6 changes: 3 additions & 3 deletions ci_scripts/deprecated.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@
# SPDX-License-Identifier: Apache-2.0

# List of deprecated packages. Deprecated packages are those which are now built
for riscv64 platforms by the upstream projects, so we don't need to maintain a
build workflow for it ourselves. Previously-built wheels should remain in the
RISE package registry.
# for riscv64 platforms by the upstream projects, so we don't need to maintain a
# build workflow for it ourselves. Previously-built wheels should remain in the
# RISE package registry.

aiohttp
blake3
Expand Down
Loading