ci_scripts: parse deprecated.txt comments dynamically - #300
Merged
Conversation
Three lines of the deprecated.txt header comment were missing their leading '#', so they parsed as package names. Fix the header, and make create_deprecation_pr() split the file at the first non-comment, non-empty line rather than a hardcoded lines[:7], so the comment block can grow or shrink without breaking the parser. Signed-off-by: Julien Stephan <jstephan@baylibre.com>
Collaborator
Author
|
This will fix issue such as this one: https://github.com/riseproject-dev/python-wheels/pull/298/changes#diff-40bd4564aa1dd30e734791d5600c1ddffd59c9bf1c17a12071f0ef7611449018L8 |
threexc
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three lines of the deprecated.txt header comment were missing their leading '#', so they parsed as package names. Fix the header, and make create_deprecation_pr() split the file at the first non-comment, non-empty line rather than a hardcoded lines[:7], so the comment block can grow or shrink without breaking the parser.