add new rhdh-playwright skill#49
Conversation
57d2ae1 to
72a0fd2
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
72a0fd2 to
6a07622
Compare
|
/cc @redhat-developer/rhdh-ui |
|
@christoph-jerolimov: GitHub didn't allow me to request PR reviews from the following users: redhat-developer/rhdh-ui. Note that only redhat-developer members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
durandom
left a comment
There was a problem hiding this comment.
Review
Well-structured skill for RHDH UI testing via `playwright-cli`. The selectors and interaction patterns are practical and reflect real RHDH page structure.
What's good
- Auth flow — guest login detection and "Enter" button click pattern matches real RHDH login pages
- Sidebar navigation — using `navigation "sidebar nav"` with role-based selectors is the correct approach
- Catalog interaction — filter patterns (Kind dropdown, search, Owner/Lifecycle/Tags comboboxes), "Personal vs All" toggle, and table navigation are all documented
- Entity page patterns — tab verification via `tablist "Tabs"`, About card structure, metadata extraction are practical
- URL patterns table — useful quick reference
Issues
-
Version bump 0.5.0 → 0.6.0 — This will conflict with PR #48 (0.5.0 → 0.5.1). If #48 merges first, this needs to be 0.5.1 → 0.6.0. More importantly, PRs #51, #54, and #58 all assume different base versions. Only one of these can merge with its current version bump — the rest need rebasing.
-
`playwright-cli` is a hard dependency. The skill mentions it in the Quick Start but doesn't have a `compatibility` frontmatter field listing it as a prerequisite (unlike the rhdh-release skill which lists `acli on PATH`). Consider adding `compatibility: "playwright-cli on PATH"` to the frontmatter.
-
No `allowed-tools` validation. The frontmatter says `allowed-tools: Bash(playwright-cli:*)` — good. But there's no gate or check in the skill body that verifies `playwright-cli` is actually installed before proceeding. A simple "run `which playwright-cli`" step at the top would save debugging time.
-
Mergeable status is UNKNOWN — may need a rebase to resolve.
Recommendation
Good skill, needs a rebase for the version and mergeability status. The content is solid.
Skill to 'chat' with your agent about a running RHDH instance. It logins, navigate, can make screenshots etc. and understands the basics of RHDH/Backstage testing.
It depends on a local installed
playwright-cli. More aboutplaywright-cli:https://playwright.dev/agent-cli/introduction
https://github.com/microsoft/playwright-cli
Example 1
details...
Example 2
details...