Skip to content

feat(overlay, rhdh-local): add branch-based metadata lookup#48

Open
dzemanov wants to merge 1 commit into
redhat-developer:mainfrom
dzemanov:plugin-metadata-overlay
Open

feat(overlay, rhdh-local): add branch-based metadata lookup#48
dzemanov wants to merge 1 commit into
redhat-developer:mainfrom
dzemanov:plugin-metadata-overlay

Conversation

@dzemanov

Copy link
Copy Markdown
Member

Summary

  • updates fetch-plugin-metadata.py script to lookup plugin metadata for branch, default main (to answer questions about what plugin tag or config to use for rhdh release 1.9 and similar)
  • fetch-plugin-metadata.py now returns also package version
  • adds dynamicArtifact and version to package's metadata-format.md
  • adds metadata lookup information to overlay skill
  • fixes outdated link to marketplace plugin -> renamed to extensions

@durandom durandom left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Good feature — branch-based metadata lookup is the missing piece for answering "what plugin version ships in RHDH 1.9?" without guessing.

Code review

The Python changes are clean:

  • _contents_url() and _raw_url() correctly use urllib.parse.quote(branch, safe="") to handle branch names with special chars (e.g., release/1.9)
  • --branch parameter is threaded through all call sites consistently (list_plugins, _list_workspace_metadata, fetch_plugin_metadata)
  • version field added to output alongside dynamicArtifact — makes the metadata actually useful for version queries
  • Human-readable output updated to show branch and version

Issues

  1. Version bump conflict. This PR bumps 0.5.0 → 0.5.1, but the current main may already be at a higher version if any of PRs #49/#58/#54 merged first. You'll need to rebase and adjust the version to whatever main is at + patch.

  2. metadata-format.md update is good. Adding dynamicArtifact and version to the documented spec captures what was already present in real metadata files but undocumented.

  3. Overlay SKILL.md — the new menu item 5 renumbers 5→6, 6→7, 7→8. The routing table is updated to match. Clean.

  4. Documentation link fixmarketplace/README.mdextensions/README.md catches a real rename. Good catch.

Recommendation

Merge-ready after a version rebase. The code changes are solid.

Assisted-By: Cursor <cursoragent@cursor.com>
Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
@durandom durandom force-pushed the plugin-metadata-overlay branch from 3c4c035 to f399a05 Compare July 10, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants