feat(overlay, rhdh-local): add branch-based metadata lookup#48
Conversation
durandom
left a comment
There was a problem hiding this comment.
Review
Good feature — branch-based metadata lookup is the missing piece for answering "what plugin version ships in RHDH 1.9?" without guessing.
Code review
The Python changes are clean:
_contents_url()and_raw_url()correctly useurllib.parse.quote(branch, safe="")to handle branch names with special chars (e.g.,release/1.9)--branchparameter is threaded through all call sites consistently (list_plugins,_list_workspace_metadata,fetch_plugin_metadata)versionfield added to output alongsidedynamicArtifact— makes the metadata actually useful for version queries- Human-readable output updated to show branch and version
Issues
-
Version bump conflict. This PR bumps 0.5.0 → 0.5.1, but the current main may already be at a higher version if any of PRs #49/#58/#54 merged first. You'll need to rebase and adjust the version to whatever main is at + patch.
-
metadata-format.mdupdate is good. AddingdynamicArtifactandversionto the documented spec captures what was already present in real metadata files but undocumented. -
Overlay SKILL.md — the new menu item 5 renumbers 5→6, 6→7, 7→8. The routing table is updated to match. Clean.
-
Documentation link fix —
marketplace/README.md→extensions/README.mdcatches a real rename. Good catch.
Recommendation
Merge-ready after a version rebase. The code changes are solid.
Assisted-By: Cursor <cursoragent@cursor.com> Signed-off-by: Dominika Zemanovicova <dzemanov@redhat.com>
3c4c035 to
f399a05
Compare
Summary
fetch-plugin-metadata.pyscript to lookup plugin metadata for branch, defaultmain(to answer questions about what plugin tag or config to use for rhdh release 1.9 and similar)fetch-plugin-metadata.pynow returns also packageversiondynamicArtifactandversionto package'smetadata-format.mdmarketplaceplugin -> renamed to extensions